From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with SMTP id 69C426B00CE for ; Wed, 23 Nov 2011 14:32:06 -0500 (EST) Subject: Re: [PATCH v7 3.2-rc2 20/30] tracing: Extract out common code for kprobes/uprobes traceevents. From: Steven Rostedt In-Reply-To: <20111118111039.10512.78989.sendpatchset@srdronam.in.ibm.com> References: <20111118110631.10512.73274.sendpatchset@srdronam.in.ibm.com> <20111118111039.10512.78989.sendpatchset@srdronam.in.ibm.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 23 Nov 2011 14:32:01 -0500 Message-ID: <1322076721.20742.66.camel@frodo> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Srikar Dronamraju Cc: Peter Zijlstra , Linus Torvalds , Oleg Nesterov , Andrew Morton , LKML , Linux-mm , Ingo Molnar , Andi Kleen , Christoph Hellwig , Roland McGrath , Thomas Gleixner , Masami Hiramatsu , Arnaldo Carvalho de Melo , Anton Arapov , Ananth N Mavinakayanahalli , Jim Keniston , Stephen Wilson On Fri, 2011-11-18 at 16:40 +0530, Srikar Dronamraju wrote: > --- /dev/null > +++ b/kernel/trace/trace_probe.h > @@ -0,0 +1,160 @@ > +/* > + * Common header file for probe-based Dynamic events. > + * > + * This program is free software; you can redistribute it and/or > modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA > 02111-1307 USA > + * > + * Copyright (C) IBM Corporation, 2010 > + * Author: Srikar Dronamraju > + * > + * Derived from kernel/trace/trace_kprobe.c written by Shouldn't the above be: include/linux/trace_kprobe.h ? Although, I would think both of these files are a bit more that derived from. I would have been a bit stronger on the wording and say: This code was copied from trace_kprobe.[ch] written by Masami ... Then say, Updates to make this generic: * Copyright (C) IBM Corporation, 2010 * Author: Srikar Dronamraju -- Steve > + * Masami Hiramatsu > + */ > + -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org