From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with SMTP id 47BAF6B00B9 for ; Wed, 23 Nov 2011 14:49:13 -0500 (EST) Subject: Re: [PATCH v7 3.2-rc2 5/30] uprobes: copy of the original instruction. From: Steven Rostedt In-Reply-To: <1322073616.14799.96.camel@twins> References: <20111118110631.10512.73274.sendpatchset@srdronam.in.ibm.com> <20111118110733.10512.11835.sendpatchset@srdronam.in.ibm.com> <1322073616.14799.96.camel@twins> Content-Type: text/plain; charset="UTF-8" Date: Wed, 23 Nov 2011 14:49:08 -0500 Message-ID: <1322077748.20742.68.camel@frodo> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Peter Zijlstra Cc: Srikar Dronamraju , Linus Torvalds , Oleg Nesterov , Andrew Morton , LKML , Linux-mm , Ingo Molnar , Andi Kleen , Christoph Hellwig , Roland McGrath , Thomas Gleixner , Masami Hiramatsu , Arnaldo Carvalho de Melo , Anton Arapov , Ananth N Mavinakayanahalli , Jim Keniston , Stephen Wilson On Wed, 2011-11-23 at 19:40 +0100, Peter Zijlstra wrote: > On Fri, 2011-11-18 at 16:37 +0530, Srikar Dronamraju wrote: > > + /* TODO : Analysis and verification of instruction */ > > As in refuse to set a breakpoint on an instruction we can't deal with? > > Do we care? The worst case we'll crash the program, but if we're allowed > setting uprobes we already have enough privileges to do that anyway, > right? Well, I wouldn't be happy if I was running a server, and needed to analyze something it was doing, and because I screwed up the location of my probe, I crash the server, made lots of people unhappy and lose my job over it. I think we do care, but it can be a TODO item. -- Steve -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org