From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx104.postini.com [74.125.245.104]) by kanga.kvack.org (Postfix) with SMTP id CACB96B02B6 for ; Wed, 14 Dec 2011 01:09:08 -0500 (EST) Subject: RE: [PATCH 1/3] slub: set a criteria for slub node partial adding From: "Alex,Shi" In-Reply-To: References: <1322814189-17318-1-git-send-email-alex.shi@intel.com> <1323419402.16790.6105.camel@debian> <6E3BC7F7C9A4BF4286DD4C043110F30B67236EED18@shsmsx502.ccr.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 14 Dec 2011 14:06:01 +0800 Message-ID: <1323842761.16790.8295.camel@debian> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: David Rientjes Cc: Christoph Lameter , "penberg@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , Eric Dumazet On Wed, 2011-12-14 at 10:36 +0800, David Rientjes wrote: > On Tue, 13 Dec 2011, David Rientjes wrote: > > > > > { > > > > n->nr_partial++; > > > > - if (tail == DEACTIVATE_TO_TAIL) > > > > - list_add_tail(&page->lru, &n->partial); > > > > - else > > > > - list_add(&page->lru, &n->partial); > > > > + list_add_tail(&page->lru, &n->partial); > > > > } > > > > > > 2 machines (one netserver, one netperf) both with 16 cores, 64GB memory > with netperf-2.4.5 comparing Linus' -git with and without this patch: > > threads SLUB SLUB+patch > 16 116614 117213 (+0.5%) > 32 216436 215065 (-0.6%) > 48 299991 299399 (-0.2%) > 64 373753 374617 (+0.2%) > 80 435688 435765 (UNCH) > 96 494630 496590 (+0.4%) > 112 546766 546259 (-0.1%) > > This suggests the difference is within the noise, so this patch neither > helps nor hurts netperf on my setup, as expected. Thanks for the data. Real netperf is hard to give enough press on SLUB. but as I mentioned before, I also didn't find real performance change on my loopback netperf testing. I retested hackbench again. about 1% performance increase still exists on my 2 sockets SNB/WSM and 4 sockets NHM. and no performance drop for other machines. Christoph, what's comments you like to offer for the results or for this code change? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org