From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx143.postini.com [74.125.245.143]) by kanga.kvack.org (Postfix) with SMTP id 333036B004D for ; Sat, 31 Dec 2011 03:45:52 -0500 (EST) From: Huang Shijie Subject: [PATCH] mm/compaction : fix the wrong return value for isolate_migratepages() Date: Sat, 31 Dec 2011 16:46:48 +0800 Message-ID: <1325321208-15778-1-git-send-email-b32955@freescale.com> MIME-Version: 1.0 Content-Type: text/plain Sender: owner-linux-mm@kvack.org List-ID: To: akpm@linux-foundation.org Cc: mgorman@suse.de, linux-mm@kvack.org, shijie8@gmail.com, Huang Shijie When we do not get any migrate page, we should return ISOLATE_NONE. If we return ISOLATE_SUCCESS in this case, we may migrate the NORMAL zone's pages to DMA zone. Signed-off-by: Huang Shijie --- mm/compaction.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index 0f12cc9..3db8630 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -376,7 +376,7 @@ static isolate_migrate_t isolate_migratepages(struct zone *zone, trace_mm_compaction_isolate_migratepages(nr_scanned, nr_isolated); - return ISOLATE_SUCCESS; + return (cc->nr_migratepages == 0) ? ISOLATE_NONE : ISOLATE_SUCCESS; } /* -- 1.7.3.2 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org