* [PATCH 1/2] memcg: root_mem_cgroup makes static
@ 2012-01-03 23:33 kosaki.motohiro
2012-01-03 23:33 ` [PATCH 2/2] memcg: mark rcu protected member as __rcu kosaki.motohiro
2012-01-04 8:46 ` [PATCH 1/2] memcg: root_mem_cgroup makes static Michal Hocko
0 siblings, 2 replies; 5+ messages in thread
From: kosaki.motohiro @ 2012-01-03 23:33 UTC (permalink / raw)
To: linux-mm, linux-kernel
Cc: KOSAKI Motohiro, KAMEZAWA Hiroyuki, Johannes Weiner, Michal Hocko,
cgroups
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
root_mem_cgroup is only referenced from memcontrol.c. It should be static.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Michal Hocko <mhocko@suse.cz>,
Cc: cgroups@vger.kernel.org
---
mm/memcontrol.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 90fdaeb..6adeeec 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -59,7 +59,7 @@
struct cgroup_subsys mem_cgroup_subsys __read_mostly;
#define MEM_CGROUP_RECLAIM_RETRIES 5
-struct mem_cgroup *root_mem_cgroup __read_mostly;
+static struct mem_cgroup *root_mem_cgroup __read_mostly;
#ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP
/* Turned on only when memory cgroup is enabled && really_do_swap_account = 1 */
--
1.7.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] memcg: mark rcu protected member as __rcu
2012-01-03 23:33 [PATCH 1/2] memcg: root_mem_cgroup makes static kosaki.motohiro
@ 2012-01-03 23:33 ` kosaki.motohiro
2012-01-04 9:01 ` Michal Hocko
2012-01-04 8:46 ` [PATCH 1/2] memcg: root_mem_cgroup makes static Michal Hocko
1 sibling, 1 reply; 5+ messages in thread
From: kosaki.motohiro @ 2012-01-03 23:33 UTC (permalink / raw)
To: linux-mm, linux-kernel
Cc: KOSAKI Motohiro, KAMEZAWA Hiroyuki, Johannes Weiner, Michal Hocko,
cgroups
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Currently "make C=2 mm/memcontrol.o" makes following warnings. fix it.
mm/memcontrol.c:4243:21: error: incompatible types in comparison expression (different address spaces)
mm/memcontrol.c:4245:21: error: incompatible types in comparison expression (different address spaces)
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Michal Hocko <mhocko@suse.cz>
Cc: cgroups@vger.kernel.org
---
mm/memcontrol.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 6adeeec..138be2b 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -195,7 +195,7 @@ struct mem_cgroup_threshold_ary {
struct mem_cgroup_thresholds {
/* Primary thresholds array */
- struct mem_cgroup_threshold_ary *primary;
+ struct mem_cgroup_threshold_ary __rcu *primary;
/*
* Spare threshold array.
* This is needed to make mem_cgroup_unregister_event() "never fail".
--
1.7.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] memcg: mark rcu protected member as __rcu
2012-01-03 23:33 ` [PATCH 2/2] memcg: mark rcu protected member as __rcu kosaki.motohiro
@ 2012-01-04 9:01 ` Michal Hocko
0 siblings, 0 replies; 5+ messages in thread
From: Michal Hocko @ 2012-01-04 9:01 UTC (permalink / raw)
To: kosaki.motohiro
Cc: linux-mm, linux-kernel, KOSAKI Motohiro, KAMEZAWA Hiroyuki,
Johannes Weiner, cgroups
On Tue 03-01-12 18:33:52, kosaki.motohiro@gmail.com wrote:
> From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
>
> Currently "make C=2 mm/memcontrol.o" makes following warnings. fix it.
>
> mm/memcontrol.c:4243:21: error: incompatible types in comparison expression (different address spaces)
> mm/memcontrol.c:4245:21: error: incompatible types in comparison expression (different address spaces)
>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Michal Hocko <mhocko@suse.cz>
> Cc: cgroups@vger.kernel.org
Looks correct.
Acked-by: Michal Hocko <mhocko@suse.cz>
Thanks
> ---
> mm/memcontrol.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 6adeeec..138be2b 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -195,7 +195,7 @@ struct mem_cgroup_threshold_ary {
>
> struct mem_cgroup_thresholds {
> /* Primary thresholds array */
> - struct mem_cgroup_threshold_ary *primary;
> + struct mem_cgroup_threshold_ary __rcu *primary;
> /*
> * Spare threshold array.
> * This is needed to make mem_cgroup_unregister_event() "never fail".
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe cgroups" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] memcg: root_mem_cgroup makes static
2012-01-03 23:33 [PATCH 1/2] memcg: root_mem_cgroup makes static kosaki.motohiro
2012-01-03 23:33 ` [PATCH 2/2] memcg: mark rcu protected member as __rcu kosaki.motohiro
@ 2012-01-04 8:46 ` Michal Hocko
2012-01-04 17:34 ` KOSAKI Motohiro
1 sibling, 1 reply; 5+ messages in thread
From: Michal Hocko @ 2012-01-04 8:46 UTC (permalink / raw)
To: kosaki.motohiro
Cc: linux-mm, linux-kernel, KOSAKI Motohiro, KAMEZAWA Hiroyuki,
Johannes Weiner, cgroups
On Tue 03-01-12 18:33:51, kosaki.motohiro@gmail.com wrote:
> From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
>
> root_mem_cgroup is only referenced from memcontrol.c. It should be static.
This has been already posted by Kirill
https://lkml.org/lkml/2011/12/23/292
>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Michal Hocko <mhocko@suse.cz>,
> Cc: cgroups@vger.kernel.org
> ---
> mm/memcontrol.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 90fdaeb..6adeeec 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -59,7 +59,7 @@
>
> struct cgroup_subsys mem_cgroup_subsys __read_mostly;
> #define MEM_CGROUP_RECLAIM_RETRIES 5
> -struct mem_cgroup *root_mem_cgroup __read_mostly;
> +static struct mem_cgroup *root_mem_cgroup __read_mostly;
>
> #ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP
> /* Turned on only when memory cgroup is enabled && really_do_swap_account = 1 */
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe cgroups" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-01-04 17:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-03 23:33 [PATCH 1/2] memcg: root_mem_cgroup makes static kosaki.motohiro
2012-01-03 23:33 ` [PATCH 2/2] memcg: mark rcu protected member as __rcu kosaki.motohiro
2012-01-04 9:01 ` Michal Hocko
2012-01-04 8:46 ` [PATCH 1/2] memcg: root_mem_cgroup makes static Michal Hocko
2012-01-04 17:34 ` KOSAKI Motohiro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).