linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Bob Liu <lliubbo@gmail.com>
To: akpm@linux-foundation.org
Cc: hughd@google.com, rientjes@google.com,
	kamezawa.hiroyu@jp.fujitsu.com, minchan.kim@gmail.com,
	linux-mm@kvack.org, Bob Liu <lliubbo@gmail.com>
Subject: [PATCH 1/2] ksm: clean up page_trans_compound_anon_split
Date: Thu, 1 Mar 2012 17:32:53 +0800	[thread overview]
Message-ID: <1330594374-13497-1-git-send-email-lliubbo@gmail.com> (raw)

Signed-off-by: Bob Liu <lliubbo@gmail.com>
---
 mm/ksm.c |   12 ++----------
 1 files changed, 2 insertions(+), 10 deletions(-)

diff --git a/mm/ksm.c b/mm/ksm.c
index 1925ffb..8e10786 100644
--- a/mm/ksm.c
+++ b/mm/ksm.c
@@ -817,7 +817,7 @@ out:
 
 static int page_trans_compound_anon_split(struct page *page)
 {
-	int ret = 0;
+	int ret = 1;
 	struct page *transhuge_head = page_trans_compound_anon(page);
 	if (transhuge_head) {
 		/* Get the reference on the head to split it. */
@@ -828,16 +828,8 @@ static int page_trans_compound_anon_split(struct page *page)
 			 */
 			if (PageAnon(transhuge_head))
 				ret = split_huge_page(transhuge_head);
-			else
-				/*
-				 * Retry later if split_huge_page run
-				 * from under us.
-				 */
-				ret = 1;
 			put_page(transhuge_head);
-		} else
-			/* Retry later if split_huge_page run from under us. */
-			ret = 1;
+		}
 	}
 	return ret;
 }
-- 
1.7.0.4


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2012-03-01  9:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-01  9:32 Bob Liu [this message]
2012-03-01  9:32 ` [PATCH 2/2] ksm: cleanup: introduce ksm_check_mm() Bob Liu
2012-03-01 20:51   ` Andrew Morton
2012-03-02  2:30     ` Bob Liu
2012-03-06 23:42   ` Hugh Dickins
2012-03-06 23:28 ` [PATCH 1/2] ksm: clean up page_trans_compound_anon_split Hugh Dickins
2012-03-07  0:11   ` Andrea Arcangeli
2012-03-07  0:26     ` Andrea Arcangeli
2012-03-07 10:39       ` Bob Liu
2012-03-07 15:47         ` Andrea Arcangeli
2012-03-07  1:21     ` Hugh Dickins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1330594374-13497-1-git-send-email-lliubbo@gmail.com \
    --to=lliubbo@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=hughd@google.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-mm@kvack.org \
    --cc=minchan.kim@gmail.com \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).