From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Mel Gorman <mgorman@suse.de>, Miao Xie <miaox@cn.fujitsu.com>,
Christoph Lameter <cl@linux.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [RFC PATCH] checkpatch: Warn on use of yield()
Date: Mon, 05 Mar 2012 18:01:20 -0800 [thread overview]
Message-ID: <1330999280.10358.3.camel@joe2Laptop> (raw)
In-Reply-To: <20120305121804.3b4daed4.akpm@linux-foundation.org>
Use of yield() is deprecated or at least generally undesirable.
Add a checkpatch warning when it's used.
Suggest cpu_relax instead.
Signed-off-by: Joe Perches <joe@perches.com>
---
> Joe, can we please have a checkpatch rule?
Something like this?
scripts/checkpatch.pl | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index e32ea7f..80ad474 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3300,6 +3300,11 @@ sub process {
"__func__ should be used instead of gcc specific __FUNCTION__\n" . $herecurr);
}
+# check for use of yield()
+ if ($line =~ /\byield\s*\(\s*\)/ {
+ WARN("YIELD",
+ "yield() is deprecated, consider cpu_relax()\n" . $herecurr);
+ }
# check for semaphores initialized locked
if ($line =~ /^.\s*sema_init.+,\W?0\W?\)/) {
WARN("CONSIDER_COMPLETION",
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-03-06 2:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 11:23 [PATCH] cpuset: mm: Remove memory barrier damage from the page allocator Mel Gorman
2012-03-02 16:19 ` Christoph Lameter
2012-03-02 17:43 ` Mel Gorman
2012-03-02 19:53 ` Christoph Lameter
2012-03-02 21:25 ` Peter Zijlstra
2012-03-02 23:47 ` David Rientjes
2012-03-05 9:44 ` Mel Gorman
2012-03-06 23:31 ` David Rientjes
2012-03-05 9:35 ` Mel Gorman
2012-03-02 21:21 ` Peter Zijlstra
2012-03-05 20:18 ` Andrew Morton
2012-03-06 2:01 ` Joe Perches [this message]
2012-03-06 12:45 ` [RFC PATCH] checkpatch: Warn on use of yield() Peter Zijlstra
2012-03-06 13:14 ` Glauber Costa
2012-03-06 13:25 ` Peter Zijlstra
2012-03-06 13:27 ` Glauber Costa
2012-03-06 17:41 ` Joe Perches
2012-03-06 17:54 ` Peter Zijlstra
2012-03-06 18:00 ` Joe Perches
2012-03-06 18:17 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330999280.10358.3.camel@joe2Laptop \
--to=joe@perches.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=miaox@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).