From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx144.postini.com [74.125.245.144]) by kanga.kvack.org (Postfix) with SMTP id AEAB36B004D for ; Mon, 26 Mar 2012 14:11:33 -0400 (EDT) From: Andrea Arcangeli Subject: [PATCH 26/39] autonuma: select_idle_sibling cleanup target assignment Date: Mon, 26 Mar 2012 19:46:13 +0200 Message-Id: <1332783986-24195-27-git-send-email-aarcange@redhat.com> In-Reply-To: <1332783986-24195-1-git-send-email-aarcange@redhat.com> References: <1332783986-24195-1-git-send-email-aarcange@redhat.com> Sender: owner-linux-mm@kvack.org List-ID: To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Hillf Danton , Dan Smith , Peter Zijlstra , Linus Torvalds , Andrew Morton , Thomas Gleixner , Ingo Molnar , Paul Turner , Suresh Siddha , Mike Galbraith , "Paul E. McKenney" , Lai Jiangshan , Bharata B Rao , Lee Schermerhorn , Rik van Riel , Johannes Weiner Cleanup the code without reusing the cpu variable to simplify readibility. Signed-off-by: Andrea Arcangeli --- kernel/sched/fair.c | 10 ++++++---- 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 0d2fe26..693adc5 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -2642,6 +2642,7 @@ static int select_idle_sibling(struct task_struct *p, int target) struct sched_domain *sd; struct sched_group *sg; int i; + bool idle_target; /* * If the task is going to be woken-up on this cpu and if it is @@ -2661,6 +2662,7 @@ static int select_idle_sibling(struct task_struct *p, int target) /* * Otherwise, iterate the domains and find an elegible idle cpu. */ + idle_target = false; sd = rcu_dereference(per_cpu(sd_llc, target)); for_each_lower_domain(sd) { sg = sd->groups; @@ -2674,7 +2676,6 @@ static int select_idle_sibling(struct task_struct *p, int target) goto next; } - cpu = -1; for_each_cpu_and(i, sched_group_cpus(sg), tsk_cpus_allowed(p)) { /* Find autonuma cpu only in idle group */ @@ -2682,10 +2683,11 @@ static int select_idle_sibling(struct task_struct *p, int target) target = i; goto done; } - if (cpu == -1) - cpu = i; + if (!idle_target) { + idle_target = true; + target = i; + } } - target = cpu; next: sg = sg->next; } while (sg != sd->groups); -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org