[PATCH] mm/memory_failure: Let the compiler add the function name

[PATCH] mm/memory_failure: Let the compiler add the function name

[Borislav Petkov]

From: Borislav Petkov <borislav.petkov@amd.com>

These things tend to get out of sync with time so let the compiler
automatically enter the current function name using __func__.

No functional change.

Cc: Andi Kleen <andi@firstfloor.org>
Cc: linux-mm@kvack.org
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
---
 mm/memory-failure.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/mm/memory-failure.c b/mm/memory-failure.c
index 56080ea36140..7d78d5ec61a7 100644
--- a/mm/memory-failure.c
+++ b/mm/memory-failure.c
@@ -1384,16 +1384,16 @@ static int get_any_page(struct page *p, unsigned long pfn, int flags)
 	 */
 	if (!get_page_unless_zero(compound_head(p))) {
 		if (PageHuge(p)) {
-			pr_info("get_any_page: %#lx free huge page\n", pfn);
+			pr_info("%s: %#lx free huge page\n", __func__, pfn);
 			ret = dequeue_hwpoisoned_huge_page(compound_head(p));
 		} else if (is_free_buddy_page(p)) {
-			pr_info("get_any_page: %#lx free buddy page\n", pfn);
+			pr_info("%s: %#lx free buddy page\n", __func__, pfn);
 			/* Set hwpoison bit while page is still isolated */
 			SetPageHWPoison(p);
 			ret = 0;
 		} else {
-			pr_info("get_any_page: %#lx: unknown zero refcount page type %lx\n",
-				pfn, p->flags);
+			pr_info("%s: %#lx: unknown zero refcount page type %lx\n",
+				__func__, pfn, p->flags);
 			ret = -EIO;
 		}
 	} else {
-- 
1.7.9.3.362.g71319

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] mm/memory_failure: Let the compiler add the function name

[Andi Kleen]

Fine for me. Andrew normally handles memory-failure.c patches these days.

-- 
ak@linux.intel.com -- Speaking for myself only.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] mm/memory_failure: Let the compiler add the function name

[David Rientjes]

On Tue, 27 Mar 2012, Borislav Petkov wrote:

> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index 56080ea36140..7d78d5ec61a7 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -1384,16 +1384,16 @@ static int get_any_page(struct page *p, unsigned long pfn, int flags)
>  	 */
>  	if (!get_page_unless_zero(compound_head(p))) {
>  		if (PageHuge(p)) {
> -			pr_info("get_any_page: %#lx free huge page\n", pfn);
> +			pr_info("%s: %#lx free huge page\n", __func__, pfn);
>  			ret = dequeue_hwpoisoned_huge_page(compound_head(p));
>  		} else if (is_free_buddy_page(p)) {
> -			pr_info("get_any_page: %#lx free buddy page\n", pfn);
> +			pr_info("%s: %#lx free buddy page\n", __func__, pfn);
>  			/* Set hwpoison bit while page is still isolated */
>  			SetPageHWPoison(p);
>  			ret = 0;
>  		} else {
> -			pr_info("get_any_page: %#lx: unknown zero refcount page type %lx\n",
> -				pfn, p->flags);
> +			pr_info("%s: %#lx: unknown zero refcount page type %lx\n",
> +				__func__, pfn, p->flags);
>  			ret = -EIO;
>  		}
>  	} else {

I agree with your change, but I'm not sure these should be pr_info() to 
start with, these seem more like debugging messages?  I can't see how 
they'd be useful in standard operation so could we just convert them to be 
debug instead?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] mm/memory_failure: Let the compiler add the function name

[Andi Kleen]

> I agree with your change, but I'm not sure these should be pr_info() to 
> start with, these seem more like debugging messages?  I can't see how 
> they'd be useful in standard operation so could we just convert them to be 
> debug instead?

Well it tells why the page recovery didn't work.

Memory recovery is a somewhat obscure path, so it's better to have
full information.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] mm/memory_failure: Let the compiler add the function name

[Fengguang Wu]

On Wed, Mar 28, 2012 at 11:09:09AM +0200, Andi Kleen wrote:
> > I agree with your change, but I'm not sure these should be pr_info() to 
> > start with, these seem more like debugging messages?  I can't see how 
> > they'd be useful in standard operation so could we just convert them to be 
> > debug instead?
> 
> Well it tells why the page recovery didn't work.
> 
> Memory recovery is a somewhat obscure path, so it's better to have
> full information.

Nod, and it won't disturb the users unless something really bad happens.

I'm fine with the patch, too.

Thanks,
Fengguang

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>