From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx143.postini.com [74.125.245.143]) by kanga.kvack.org (Postfix) with SMTP id 9BBC46B0044 for ; Mon, 23 Apr 2012 17:30:08 -0400 (EDT) Received: by dadq36 with SMTP id q36so1408dad.8 for ; Mon, 23 Apr 2012 14:30:07 -0700 (PDT) From: Sasikantha babu Subject: [PATCH v2] mm:vmstat - Removed debug fs entries on failure of file creation and made extfrag_debug_root dentry local Date: Tue, 24 Apr 2012 02:59:53 +0530 Message-Id: <1335216593-8890-1-git-send-email-sasikanth.v19@gmail.com> Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton , Mel Gorman , Christoph Lameter , David Rientjes , KOSAKI Motohiro Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sasikantha babu Removed debug fs files and directory on failure. Since no one using "extfrag_debug_root" dentry outside of function extfrag_debug_init made it local to the function. Signed-off-by: Sasikantha babu --- mm/vmstat.c | 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/mm/vmstat.c b/mm/vmstat.c index f600557..41447fc 100644 --- a/mm/vmstat.c +++ b/mm/vmstat.c @@ -1220,7 +1220,6 @@ module_init(setup_vmstat) #if defined(CONFIG_DEBUG_FS) && defined(CONFIG_COMPACTION) #include -static struct dentry *extfrag_debug_root; /* * Return an index indicating how much of the available free memory is @@ -1358,19 +1357,24 @@ static const struct file_operations extfrag_file_ops = { static int __init extfrag_debug_init(void) { + struct dentry *extfrag_debug_root; + extfrag_debug_root = debugfs_create_dir("extfrag", NULL); if (!extfrag_debug_root) return -ENOMEM; if (!debugfs_create_file("unusable_index", 0444, extfrag_debug_root, NULL, &unusable_file_ops)) - return -ENOMEM; + goto fail; if (!debugfs_create_file("extfrag_index", 0444, extfrag_debug_root, NULL, &extfrag_file_ops)) - return -ENOMEM; + goto fail; return 0; +fail: + debugfs_remove_recursive(extfrag_debug_root); + return -ENOMEM; } module_init(extfrag_debug_init); -- 1.7.3.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org