linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] cma: fix migration mode
@ 2012-05-10 15:33 Minchan Kim
  2012-05-11  2:19 ` Michal Nazarewicz
  0 siblings, 1 reply; 3+ messages in thread
From: Minchan Kim @ 2012-05-10 15:33 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-mm, linux-kernel, Minchan Kim, Marek Szyprowski

__alloc_contig_migrate_range calls migrate_pages with wrong argument
for migrate_mode. Fix it.

Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Minchan Kim <minchan@kernel.org>
---
 mm/page_alloc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 4d926f1..9febc62 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -5689,7 +5689,7 @@ static int __alloc_contig_migrate_range(unsigned long start, unsigned long end)
 
 		ret = migrate_pages(&cc.migratepages,
 				    __alloc_contig_migrate_alloc,
-				    0, false, true);
+				    0, false, MIGRATE_SYNC);
 	}
 
 	putback_lru_pages(&cc.migratepages);
-- 
1.7.9.5

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] cma: fix migration mode
  2012-05-10 15:33 [PATCH] cma: fix migration mode Minchan Kim
@ 2012-05-11  2:19 ` Michal Nazarewicz
  2012-05-11  8:13   ` Marek Szyprowski
  0 siblings, 1 reply; 3+ messages in thread
From: Michal Nazarewicz @ 2012-05-11  2:19 UTC (permalink / raw)
  To: Andrew Morton, Minchan Kim; +Cc: linux-mm, linux-kernel, Marek Szyprowski

On Thu, 10 May 2012 08:33:23 -0700, Minchan Kim <minchan@kernel.org> wrote:
> __alloc_contig_migrate_range calls migrate_pages with wrong argument
> for migrate_mode. Fix it.
>
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Minchan Kim <minchan@kernel.org>

Acked-by: Michal Nazarewicz <mina86@mina86.com>

> ---
>  mm/page_alloc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 4d926f1..9febc62 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -5689,7 +5689,7 @@ static int __alloc_contig_migrate_range(unsigned long start, unsigned long end)
> 		ret = migrate_pages(&cc.migratepages,
>  				    __alloc_contig_migrate_alloc,
> -				    0, false, true);
> +				    0, false, MIGRATE_SYNC);
>  	}
> 	putback_lru_pages(&cc.migratepages);


-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] cma: fix migration mode
  2012-05-11  2:19 ` Michal Nazarewicz
@ 2012-05-11  8:13   ` Marek Szyprowski
  0 siblings, 0 replies; 3+ messages in thread
From: Marek Szyprowski @ 2012-05-11  8:13 UTC (permalink / raw)
  To: 'Michal Nazarewicz', 'Andrew Morton',
	'Minchan Kim'
  Cc: linux-mm, linux-kernel

Hello,

On Friday, May 11, 2012 4:19 AM Michal Nazarewicz wrote:

> On Thu, 10 May 2012 08:33:23 -0700, Minchan Kim <minchan@kernel.org> wrote:
> > __alloc_contig_migrate_range calls migrate_pages with wrong argument
> > for migrate_mode. Fix it.
> >
> > Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> > Signed-off-by: Minchan Kim <minchan@kernel.org>
> 
> Acked-by: Michal Nazarewicz <mina86@mina86.com>
> 
> > ---
> >  mm/page_alloc.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> > index 4d926f1..9febc62 100644
> > --- a/mm/page_alloc.c
> > +++ b/mm/page_alloc.c
> > @@ -5689,7 +5689,7 @@ static int __alloc_contig_migrate_range(unsigned long start, unsigned
> long end)
> > 		ret = migrate_pages(&cc.migratepages,
> >  				    __alloc_contig_migrate_alloc,
> > -				    0, false, true);
> > +				    0, false, MIGRATE_SYNC);
> >  	}
> > 	putback_lru_pages(&cc.migratepages);
> 

Thanks for the patch, I will add it to my kernel tree.

Best regards
-- 
Marek Szyprowski
Samsung Poland R&D Center


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-05-11  8:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-10 15:33 [PATCH] cma: fix migration mode Minchan Kim
2012-05-11  2:19 ` Michal Nazarewicz
2012-05-11  8:13   ` Marek Szyprowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).