* [PATCH] ARM: use common utility function in dma
@ 2012-05-11 7:03 Minchan Kim
0 siblings, 0 replies; only message in thread
From: Minchan Kim @ 2012-05-11 7:03 UTC (permalink / raw)
Cc: linux-arm-kernel, linux-kernel, linux-mm, Minchan Kim,
Russell King
mm provides alloc_pages_exact so use it instead of open coded hack.
Cc: Russell King <linux@arm.linux.org.uk>
Signed-off-by: Minchan Kim <minchan@kernel.org>
---
arch/arm/mm/dma-mapping.c | 23 +++++------------------
1 file changed, 5 insertions(+), 18 deletions(-)
diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
index b982602..98c9bbd 100644
--- a/arch/arm/mm/dma-mapping.c
+++ b/arch/arm/mm/dma-mapping.c
@@ -184,20 +184,12 @@ static void __dma_clear_buffer(struct page *page, size_t size)
*/
static struct page *__dma_alloc_buffer(struct device *dev, size_t size, gfp_t gfp)
{
- unsigned long order = get_order(size);
- struct page *page, *p, *e;
-
- page = alloc_pages(gfp, order);
- if (!page)
+ struct page *page;
+ void *addr = alloc_pages_exact(size, gfp);
+ if (!addr)
return NULL;
- /*
- * Now split the huge page and free the excess pages
- */
- split_page(page, order);
- for (p = page + (size >> PAGE_SHIFT), e = page + (1 << order); p < e; p++)
- __free_page(p);
-
+ page = virt_to_page(addr);
__dma_clear_buffer(page, size);
return page;
@@ -208,12 +200,7 @@ static struct page *__dma_alloc_buffer(struct device *dev, size_t size, gfp_t gf
*/
static void __dma_free_buffer(struct page *page, size_t size)
{
- struct page *e = page + (size >> PAGE_SHIFT);
-
- while (page < e) {
- __free_page(page);
- page++;
- }
+ free_pages_exact(page_address(page), size);
}
#ifdef CONFIG_MMU
--
1.7.9.5
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-05-11 7:04 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-11 7:03 [PATCH] ARM: use common utility function in dma Minchan Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).