From: Gavin Shan <shangw@linux.vnet.ibm.com>
To: linux-mm@kvack.org
Cc: hannes@cmpxchg.org, akpm@linux-foundation.org,
Gavin Shan <shangw@linux.vnet.ibm.com>
Subject: [PATCH] mm/slab: remove duplicate check
Date: Fri, 11 May 2012 17:16:09 +0800 [thread overview]
Message-ID: <1336727769-19555-1-git-send-email-shangw@linux.vnet.ibm.com> (raw)
While allocateing pages using buddy allocator, the compound page
is probably split up to free pages. Under the circumstance, the
compound page should be destroied by function destroy_compound_page().
However, there has duplicate check to judge if the page is compound
one.
The patch removes the duplicate check since the function compound_order()
will returns 0 while the page hasn't PG_head set in function destroy_compound_page().
That's to say, the function destroy_compound_page() needn't check
PG_head any more through function PageHead().
Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
---
mm/page_alloc.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index a712fb9..1277632 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -363,8 +363,7 @@ static int destroy_compound_page(struct page *page, unsigned long order)
int nr_pages = 1 << order;
int bad = 0;
- if (unlikely(compound_order(page) != order) ||
- unlikely(!PageHead(page))) {
+ if (unlikely(compound_order(page) != order)) {
bad_page(page);
bad++;
}
--
1.7.5.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2012-05-11 9:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 9:16 Gavin Shan [this message]
2012-05-14 20:42 ` [PATCH] mm/slab: remove duplicate check Johannes Weiner
2012-05-15 9:19 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336727769-19555-1-git-send-email-shangw@linux.vnet.ibm.com \
--to=shangw@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).