linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Glauber Costa <glommer@parallels.com>
To: cgroups@vger.kernel.org
Cc: linux-mm@kvack.org, devel@openvz.org,
	kamezawa.hiroyu@jp.fujitsu.com, netdev@vger.kernel.org,
	Tejun Heo <tj@kernel.org>, Li Zefan <lizefan@huawei.com>
Subject: [PATCH v5 0/2] fix static_key disabling problem in memcg
Date: Fri, 11 May 2012 17:11:15 -0300	[thread overview]
Message-ID: <1336767077-25351-1-git-send-email-glommer@parallels.com> (raw)

Hi, Tejun, Kame,

This series is composed of the two patches of the last fix, with no changes
(only exception is the removal of x = false assignments that Tejun requested,
that is done now). Note also that patch 1 of this series was reused by me
in the slab accounting patches for memcg.

The first patch, that adds a mutex to memcg is dropped. I didn't posted it
before so I could wait for Kame to get back from his vacations and properly
review it.

Kame: Steven Rostedt pointed out that our analysis of the static branch updates
were wrong, so the mutex is really not needed. 

The key to understand that, is that atomic_inc_not_zero will only return right
away if the value is not yet zero - as the name implies - but the update in the
atomic variable only happens after the code is patched.

Therefore, if two callers enters with a key value of zero, both will be held at
the jump_label_lock() call, effectively guaranteeing the behavior we need.

Glauber Costa (2):
  Always free struct memcg through schedule_work()
  decrement static keys on real destroy time

 include/net/sock.h        |    9 ++++++++
 mm/memcontrol.c           |   50 +++++++++++++++++++++++++++++++++-----------
 net/ipv4/tcp_memcontrol.c |   32 ++++++++++++++++++++++------
 3 files changed, 71 insertions(+), 20 deletions(-)

-- 
1.7.7.6

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2012-05-11 20:13 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-11 20:11 Glauber Costa [this message]
2012-05-11 20:11 ` [PATCH v5 1/2] Always free struct memcg through schedule_work() Glauber Costa
2012-05-14  0:56   ` KAMEZAWA Hiroyuki
2012-05-11 20:11 ` [PATCH v5 2/2] decrement static keys on real destroy time Glauber Costa
2012-05-14  0:59   ` KAMEZAWA Hiroyuki
2012-05-16  6:03     ` Glauber Costa
2012-05-16  7:04       ` Glauber Costa
2012-05-16  8:28         ` KAMEZAWA Hiroyuki
2012-05-16  8:30           ` Glauber Costa
2012-05-16  8:37           ` Glauber Costa
2012-05-14  1:38   ` Li Zefan
2012-05-16  7:03     ` Glauber Costa
2012-05-16 20:57       ` Andrew Morton
2012-05-14 18:12   ` Tejun Heo
2012-05-16 21:06   ` Andrew Morton
2012-05-17  3:06     ` Glauber Costa
2012-05-17  5:37       ` Andrew Morton
2012-05-17  9:52         ` Glauber Costa
2012-05-17 10:18           ` KAMEZAWA Hiroyuki
2012-05-17 10:22             ` Glauber Costa
2012-05-17 10:27               ` KAMEZAWA Hiroyuki
2012-05-17 15:19           ` Tejun Heo
2012-05-17 17:02           ` Andrew Morton
2012-05-16 21:13   ` Andrew Morton
2012-05-17  0:07     ` KAMEZAWA Hiroyuki
2012-05-17  3:09     ` Glauber Costa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1336767077-25351-1-git-send-email-glommer@parallels.com \
    --to=glommer@parallels.com \
    --cc=cgroups@vger.kernel.org \
    --cc=devel@openvz.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-mm@kvack.org \
    --cc=lizefan@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).