linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@suse.cz>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org,
	Johannes Weiner <hannes@cmpxchg.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Mel Gorman <mel@csn.ul.ie>, Minchan Kim <minchan@kernel.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Rik van Riel <riel@redhat.com>
Subject: [PATCH] mm: consider all swapped back pages in used-once logic
Date: Thu, 17 May 2012 11:13:53 +0200	[thread overview]
Message-ID: <1337246033-13719-1-git-send-email-mhocko@suse.cz> (raw)

[64574746 vmscan: detect mapped file pages used only once] made mapped pages
have another round in inactive list because they might be just short
lived and so we could consider them again next time. This heuristic
helps to reduce pressure on the active list with a streaming IO
worklods.
This patch fixes a regression introduced by this commit for heavy shmem
based workloads because unlike Anon pages, which are excluded from this
heuristic because they are usually long lived, shmem pages are handled
as a regular page cache.
This doesn't work quite well, unfortunately, if the workload is mostly
backed by shmem (in memory database sitting on 80% of memory) with a
streaming IO in the background (backup - up to 20% of memory). Anon
inactive list is full of (dirty) shmem pages when watermarks are
hit. Shmem pages are kept in the inactive list (they are referenced)
in the first round and it is hard to reclaim anything else so we reach
lower scanning priorities very quickly which leads to an excessive swap
out.

Let's fix this by excluding all swap backed pages (they tend to be long
lived wrt. the regular page cache anyway) from used-once heuristic and
rather activate them if they are referenced.

CC: Johannes Weiner <hannes@cmpxchg.org>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: Mel Gorman <mel@csn.ul.ie>
CC: Minchan Kim <minchan@kernel.org>
CC: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
CC: Rik van Riel <riel@redhat.com>
CC: stable [2.6.34+]
Signed-off-by: Michal Hocko <mhocko@suse.cz>
---
 mm/vmscan.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index 33dc256..0932dc2 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -722,7 +722,7 @@ static enum page_references page_check_references(struct page *page,
 		return PAGEREF_RECLAIM;
 
 	if (referenced_ptes) {
-		if (PageAnon(page))
+		if (PageSwapBacked(page))
 			return PAGEREF_ACTIVATE;
 		/*
 		 * All mapped pages start out with page table
-- 
1.7.10

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2012-05-17  9:14 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-17  9:13 Michal Hocko [this message]
2012-05-17  9:24 ` [PATCH] mm: consider all swapped back pages in used-once logic Andrew Morton
2012-05-17 12:10   ` Michal Hocko
2012-05-17 20:23     ` Andrew Morton
2012-05-18  6:50       ` Michal Hocko
2012-05-17 13:14 ` Rik van Riel
2012-05-17 19:54 ` Johannes Weiner
2012-05-21  2:51   ` Zheng Liu
2012-05-21  7:36     ` Johannes Weiner
2012-05-21  8:59       ` Zheng Liu
2012-05-21  9:37         ` Johannes Weiner
2012-05-21 11:07           ` Zheng Liu
2012-06-23 11:04             ` Johannes Weiner
2012-06-23 15:22               ` Rik van Riel
2012-06-24 23:53               ` Minchan Kim
2012-06-25  8:08                 ` Johannes Weiner
2012-06-25  8:25                   ` Minchan Kim
2012-06-26 13:51                     ` Johannes Weiner
2012-06-26 23:47                       ` Minchan Kim
2012-05-18  0:40 ` Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337246033-13719-1-git-send-email-mhocko@suse.cz \
    --to=mhocko@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=minchan@kernel.org \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).