From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx149.postini.com [74.125.245.149]) by kanga.kvack.org (Postfix) with SMTP id 70B356B0069 for ; Tue, 29 May 2012 09:51:30 -0400 (EDT) Message-ID: <1338299468.26856.80.camel@twins> Subject: Re: [PATCH 14/35] autonuma: knuma_migrated per NUMA node queues From: Peter Zijlstra Date: Tue, 29 May 2012 15:51:08 +0200 In-Reply-To: <1337965359-29725-15-git-send-email-aarcange@redhat.com> References: <1337965359-29725-1-git-send-email-aarcange@redhat.com> <1337965359-29725-15-git-send-email-aarcange@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Sender: owner-linux-mm@kvack.org List-ID: To: Andrea Arcangeli Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Hillf Danton , Dan Smith , Linus Torvalds , Andrew Morton , Thomas Gleixner , Ingo Molnar , Paul Turner , Suresh Siddha , Mike Galbraith , "Paul E. McKenney" , Lai Jiangshan , Bharata B Rao , Lee Schermerhorn , Rik van Riel , Johannes Weiner , Srivatsa Vaddagiri , Christoph Lameter On Fri, 2012-05-25 at 19:02 +0200, Andrea Arcangeli wrote: > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index 41aa49b..8e578e6 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -666,6 +666,12 @@ typedef struct pglist_data { > struct task_struct *kswapd; > int kswapd_max_order; > enum zone_type classzone_idx; > +#ifdef CONFIG_AUTONUMA > + spinlock_t autonuma_lock; > + struct list_head autonuma_migrate_head[MAX_NUMNODES]; > + unsigned long autonuma_nr_migrate_pages; > + wait_queue_head_t autonuma_knuma_migrated_wait; > +#endif > } pg_data_t; > =20 > #define node_present_pages(nid) (NODE_DATA(nid)->node_present_pages) O(nr_nodes^2) data.. ISTR people rewriting a certain slab allocator to get rid of that :-) Also, don't forget that MAX_NUMNODES is an unconditional 512 on distro kernels, even when we only have 2. Now the total wasted space isn't too bad since its only 16 bytes, totaling a whole 2M for a 256 node system. But still, something like that wants at least a mention somewhere. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org