From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx109.postini.com [74.125.245.109]) by kanga.kvack.org (Postfix) with SMTP id F13E06B005C for ; Sun, 10 Jun 2012 00:20:54 -0400 (EDT) Received: by dakp5 with SMTP id p5so4884340dak.14 for ; Sat, 09 Jun 2012 21:20:54 -0700 (PDT) From: Wanpeng Li Subject: [PATCH] page-writeback.c: fix update bandwidth time judgment error Date: Sun, 10 Jun 2012 12:20:05 +0800 Message-Id: <1339302005-366-1-git-send-email-liwp.linux@gmail.com> Sender: owner-linux-mm@kvack.org List-ID: To: Fengguang Wu Cc: LKML , Jan Kara , Andrew Morton , Peter Zijlstra , Johannes Weiner , linux-mm@kvack.org, Gavin Shan , Wanpeng Li , Wanpeng Li From: Wanpneg Li Since bdi_update_bandwidth function should estimate write bandwidth at 200ms intervals, so the time is bdi->bw_time_stamp + BANDWIDTH_INTERVAL == jiffies, but if use time_is_after_eq_jiffies intervals will be bdi->bw_time_stamp + BANDWIDTH_INTERVAL + 1. Signed-off-by: Wanpeng Li --- mm/page-writeback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page-writeback.c b/mm/page-writeback.c index c833bf0..099e225 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c @@ -1032,7 +1032,7 @@ static void bdi_update_bandwidth(struct backing_dev_info *bdi, unsigned long bdi_dirty, unsigned long start_time) { - if (time_is_after_eq_jiffies(bdi->bw_time_stamp + BANDWIDTH_INTERVAL)) + if (time_is_after_jiffies(bdi->bw_time_stamp + BANDWIDTH_INTERVAL)) return; spin_lock(&bdi->wb.list_lock); __bdi_update_bandwidth(bdi, thresh, bg_thresh, dirty, -- 1.7.9.5 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org