From: Sasha Levin <levinsasha928@gmail.com>
To: konrad@darnok.org
Cc: Dan Magenheimer <dan.magenheimer@oracle.com>,
Minchan Kim <minchan@kernel.org>,
Konrad Wilk <konrad.wilk@oracle.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 04/10] mm: frontswap: split out __frontswap_unuse_pages
Date: Mon, 11 Jun 2012 16:38:43 +0200 [thread overview]
Message-ID: <1339425523.4999.56.camel@lappy> (raw)
In-Reply-To: <CAPbh3ruqk+dU4C8b=mSko+2EjumrswgkO6CUp73=8thvLNAA8A@mail.gmail.com>
On Mon, 2012-06-11 at 10:31 -0400, Konrad Rzeszutek Wilk wrote:
> > I'm not sure of the correct kernel style but I like the fact
> > that assert_spin_locked both documents the lock requirement and tests
> > it at runtime.
>
> The kernel style is to do "
> 3) Separate your changes.
>
> Separate _logical changes_ into a single patch file.
> "
>
> So it is fine, but it should be in its own patch.
It is one logical change: I've moved a block of code that has to be
locked in the swap mutex into it's own function, adding the spinlock
assertion isn't new code, nor it relates to any new code. It's there to
assert that what happened before still happens now.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-11 14:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-10 10:50 [PATCH v3 00/10] minor frontswap cleanups and tracing support Sasha Levin
2012-06-10 10:50 ` [PATCH v3 01/10] mm: frontswap: remove casting from function calls through ops structure Sasha Levin
2012-06-11 5:20 ` Minchan Kim
2012-06-10 10:51 ` [PATCH v3 02/10] mm: frontswap: trivial coding convention issues Sasha Levin
2012-06-11 5:24 ` Minchan Kim
2012-06-10 10:51 ` [PATCH v3 03/10] mm: frontswap: split out __frontswap_curr_pages Sasha Levin
2012-06-11 5:28 ` Minchan Kim
2012-06-10 10:51 ` [PATCH v3 04/10] mm: frontswap: split out __frontswap_unuse_pages Sasha Levin
2012-06-11 5:43 ` Minchan Kim
2012-06-11 10:30 ` Sasha Levin
2012-06-11 14:27 ` Dan Magenheimer
2012-06-11 14:31 ` Konrad Rzeszutek Wilk
2012-06-11 14:38 ` Sasha Levin [this message]
2012-06-10 10:51 ` [PATCH v3 05/10] mm: frontswap: split frontswap_shrink further to simplify locking Sasha Levin
2012-06-11 5:49 ` Minchan Kim
2012-06-10 10:51 ` [PATCH v3 06/10] mm: frontswap: make all branches of if statement in put page consistent Sasha Levin
2012-06-11 5:52 ` Minchan Kim
2012-06-10 10:51 ` [PATCH v3 07/10] mm: frontswap: remove unnecessary check during initialization Sasha Levin
2012-06-11 5:54 ` Minchan Kim
2012-06-10 10:51 ` [PATCH v3 08/10] mm: frontswap: add tracing support Sasha Levin
2012-06-11 6:12 ` Minchan Kim
2012-06-11 8:33 ` Pekka Enberg
2012-06-11 10:39 ` Sasha Levin
2012-06-10 10:51 ` [PATCH v3 09/10] mm: frontswap: split out function to clear a page out Sasha Levin
2012-06-11 6:16 ` Minchan Kim
2012-06-10 10:51 ` [PATCH v3 10/10] mm: frontswap: remove unneeded headers Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339425523.4999.56.camel@lappy \
--to=levinsasha928@gmail.com \
--cc=dan.magenheimer@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=konrad@darnok.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).