From: Gavin Shan <shangw@linux.vnet.ibm.com>
To: linux-mm@kvack.org
Cc: rientjes@google.com, hannes@cmpxchg.org,
akpm@linux-foundation.org, Gavin Shan <shangw@linux.vnet.ibm.com>
Subject: [PATCH 4/5] mm/sparse: more check on mem_section number
Date: Sat, 23 Jun 2012 23:52:55 +0800 [thread overview]
Message-ID: <1340466776-4976-4-git-send-email-shangw@linux.vnet.ibm.com> (raw)
In-Reply-To: <1340466776-4976-1-git-send-email-shangw@linux.vnet.ibm.com>
Function __section_nr() was implemented to retrieve the corresponding
memory section number according to its descriptor. It's possible that
the specified memory section descriptor isn't existing in the global
array. So here to add more check on that and report error for wrong
case.
Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
---
mm/sparse.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/mm/sparse.c b/mm/sparse.c
index bae8f2d..a8b99d3 100644
--- a/mm/sparse.c
+++ b/mm/sparse.c
@@ -160,6 +160,8 @@ int __section_nr(struct mem_section* ms)
break;
}
+ VM_BUG_ON(root_nr == NR_SECTION_ROOTS);
+
return (root_nr * SECTIONS_PER_ROOT) + (ms - root);
}
--
1.7.9.5
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-23 15:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-23 15:52 [PATCH 1/5] mm/sparse: check size of struct mm_section Gavin Shan
2012-06-23 15:52 ` [PATCH 2/5] mm/sparse: optimize sparse_index_alloc Gavin Shan
2012-06-25 15:30 ` Michal Hocko
2012-06-26 6:07 ` Gavin Shan
2012-06-26 7:04 ` Michal Hocko
2012-06-26 7:13 ` Gavin Shan
2012-06-23 15:52 ` [PATCH 3/5] mm/sparse: fix possible memory leak Gavin Shan
2012-06-25 15:48 ` Michal Hocko
2012-06-26 6:11 ` Gavin Shan
2012-06-26 7:14 ` Michal Hocko
2012-06-26 7:17 ` Gavin Shan
2012-06-23 15:52 ` Gavin Shan [this message]
2012-06-26 16:15 ` [PATCH 4/5] mm/sparse: more check on mem_section number Dave Hansen
2012-06-27 0:29 ` Gavin Shan
2012-06-23 15:52 ` [PATCH 5/5] mm/sparse: return 0 if root mem_section exists Gavin Shan
2012-06-24 19:18 ` KOSAKI Motohiro
2012-06-25 1:09 ` Gavin Shan
2012-06-25 15:39 ` Michal Hocko
2012-06-25 16:03 ` [PATCH 1/5] mm/sparse: check size of struct mm_section Michal Hocko
2012-06-25 16:35 ` Gavin Shan
2012-06-26 7:39 ` Michal Hocko
2012-06-26 7:48 ` Gavin Shan
2012-06-26 8:06 ` Michal Hocko
2012-06-26 8:24 ` Gavin Shan
2012-06-26 17:57 ` Michal Hocko
2012-06-27 3:01 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340466776-4976-4-git-send-email-shangw@linux.vnet.ibm.com \
--to=shangw@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).