From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx102.postini.com [74.125.245.102]) by kanga.kvack.org (Postfix) with SMTP id 13F0A6B0325 for ; Mon, 25 Jun 2012 05:53:14 -0400 (EDT) Received: from /spool/local by e28smtp05.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 25 Jun 2012 15:23:10 +0530 Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q5P9r8Zx1835272 for ; Mon, 25 Jun 2012 15:23:08 +0530 Received: from d28av02.in.ibm.com (loopback [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q5PFNkoN015829 for ; Tue, 26 Jun 2012 01:23:46 +1000 Message-ID: <1340617984.13778.37.camel@ThinkPad-T420> Subject: [PATCH SLUB 1/2] duplicate the cache name in saved_alias list From: Li Zhong Date: Mon, 25 Jun 2012 17:53:04 +0800 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: owner-linux-mm@kvack.org List-ID: To: LKML Cc: Christoph Lameter , Pekka Enberg , Matt Mackall , Benjamin Herrenschmidt , Paul Mackerras , linux-mm , PowerPC email list SLUB duplicates the cache name in kmem_cache_create(). However if the cache could be merged to others during early booting, the name pointer is saved in saved_alias list, and the string needs to be kept valid before slab_sysfs_init() is called. This patch tries to duplicate the cache name in saved_alias list, so that the cache name could be safely kfreed after calling kmem_cache_create(), if that name is kmalloced. Signed-off-by: Li Zhong --- mm/slub.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 8c691fa..3dc8ed5 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -5373,6 +5373,11 @@ static int sysfs_slab_alias(struct kmem_cache *s, const char *name) al->s = s; al->name = name; + al->name = kstrdup(name, GFP_KERNEL); + if (!al->name) { + kfree(al); + return -ENOMEM; + } al->next = alias_list; alias_list = al; return 0; @@ -5409,6 +5414,7 @@ static int __init slab_sysfs_init(void) if (err) printk(KERN_ERR "SLUB: Unable to add boot slab alias" " %s to sysfs\n", s->name); + kfree(al->name); kfree(al); } -- 1.7.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org