From: Gavin Shan <shangw@linux.vnet.ibm.com>
To: linux-mm@kvack.org
Cc: xiyou.wangcong@gmail.com, akpm@linux-foundation.org,
Gavin Shan <shangw@linux.vnet.ibm.com>
Subject: [PATCH] mm/buddy: more comments for skip_free_areas_node()
Date: Fri, 6 Jul 2012 11:24:57 +0800 [thread overview]
Message-ID: <1341545097-9933-1-git-send-email-shangw@linux.vnet.ibm.com> (raw)
The initial idea comes from Cong Wang. We're running out of memory
while calling function skip_free_areas_node(). So it would be unsafe
to allocate more memory from either stack or heap. The patche adds
more comments to address that.
Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
---
mm/page_alloc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 4403009..c74f5a9 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -2737,6 +2737,9 @@ void si_meminfo_node(struct sysinfo *val, int nid)
/*
* Determine whether the node should be displayed or not, depending on whether
* SHOW_MEM_FILTER_NODES was passed to show_free_areas().
+ *
+ * We're running out of memory while calling the function. So don't allocate
+ * more memory from either stack or heap.
*/
bool skip_free_areas_node(unsigned int flags, int nid)
{
--
1.7.9.5
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2012-07-06 3:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-06 3:24 Gavin Shan [this message]
2012-07-06 5:42 ` [PATCH] mm/buddy: more comments for skip_free_areas_node() Cong Wang
2012-07-06 5:46 ` Gavin Shan
2012-07-09 21:21 ` David Rientjes
2012-07-10 0:51 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341545097-9933-1-git-send-email-shangw@linux.vnet.ibm.com \
--to=shangw@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).