* [PATCH] mm/memcg: add BUG() to mem_cgroup_reset @ 2012-07-06 3:44 Wanpeng Li 2012-07-06 5:19 ` Gavin Shan 2012-07-06 8:22 ` Johannes Weiner 0 siblings, 2 replies; 5+ messages in thread From: Wanpeng Li @ 2012-07-06 3:44 UTC (permalink / raw) To: Andrew Morton Cc: Johannes Weiner, Michal Hocko, KAMEZAWA Hiroyuki, cgroups, linux-mm, linux-kernel, Wanpeng Li From: Wanpeng Li <liwp@linux.vnet.ibm.com> Branch in mem_cgroup_reset only can be RES_MAX_USAGE, RES_FAILCNT. Signed-off-by: Wanpeng Li <liwp.linux@gmail.com> --- mm/memcontrol.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index a501660..5e4d1ab 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -3976,6 +3976,8 @@ static int mem_cgroup_reset(struct cgroup *cont, unsigned int event) else res_counter_reset_failcnt(&memcg->memsw); break; + default: + BUG(); } return 0; -- 1.7.5.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] mm/memcg: add BUG() to mem_cgroup_reset 2012-07-06 3:44 [PATCH] mm/memcg: add BUG() to mem_cgroup_reset Wanpeng Li @ 2012-07-06 5:19 ` Gavin Shan 2012-07-06 5:37 ` Wanpeng Li 2012-07-06 8:22 ` Johannes Weiner 1 sibling, 1 reply; 5+ messages in thread From: Gavin Shan @ 2012-07-06 5:19 UTC (permalink / raw) To: Wanpeng Li Cc: Andrew Morton, Johannes Weiner, Michal Hocko, KAMEZAWA Hiroyuki, cgroups, linux-mm, linux-kernel On Fri, Jul 06, 2012 at 11:44:57AM +0800, Wanpeng Li wrote: >From: Wanpeng Li <liwp@linux.vnet.ibm.com> > >Branch in mem_cgroup_reset only can be RES_MAX_USAGE, RES_FAILCNT. > >Signed-off-by: Wanpeng Li <liwp.linux@gmail.com> >--- > mm/memcontrol.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > >diff --git a/mm/memcontrol.c b/mm/memcontrol.c >index a501660..5e4d1ab 100644 >--- a/mm/memcontrol.c >+++ b/mm/memcontrol.c >@@ -3976,6 +3976,8 @@ static int mem_cgroup_reset(struct cgroup *cont, unsigned int event) > else > res_counter_reset_failcnt(&memcg->memsw); > break; >+ default: >+ BUG(); It might be not convinced to have "BUG()" here. You might add something for debugging purpose. For example, default: printk(KERN_WARNING "%s: Unrecognized name %d\n", __func__, name); Thanks, Gavin > } > > return 0; >-- >1.7.5.4 > >-- >To unsubscribe, send a message with 'unsubscribe linux-mm' in >the body to majordomo@kvack.org. For more info on Linux MM, >see: http://www.linux-mm.org/ . >Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mm/memcg: add BUG() to mem_cgroup_reset 2012-07-06 5:19 ` Gavin Shan @ 2012-07-06 5:37 ` Wanpeng Li 0 siblings, 0 replies; 5+ messages in thread From: Wanpeng Li @ 2012-07-06 5:37 UTC (permalink / raw) To: Gavin Shan Cc: Andrew Morton, Johannes Weiner, Michal Hocko, KAMEZAWA Hiroyuki, cgroups, linux-mm, linux-kernel On Fri, Jul 06, 2012 at 01:19:16PM +0800, Gavin Shan wrote: >On Fri, Jul 06, 2012 at 11:44:57AM +0800, Wanpeng Li wrote: >>From: Wanpeng Li <liwp@linux.vnet.ibm.com> >> >>Branch in mem_cgroup_reset only can be RES_MAX_USAGE, RES_FAILCNT. >> >>Signed-off-by: Wanpeng Li <liwp.linux@gmail.com> >>--- >> mm/memcontrol.c | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >>diff --git a/mm/memcontrol.c b/mm/memcontrol.c >>index a501660..5e4d1ab 100644 >>--- a/mm/memcontrol.c >>+++ b/mm/memcontrol.c >>@@ -3976,6 +3976,8 @@ static int mem_cgroup_reset(struct cgroup *cont, unsigned int event) >> else >> res_counter_reset_failcnt(&memcg->memsw); >> break; >>+ default: >>+ BUG(); > >It might be not convinced to have "BUG()" here. You might add >something for debugging purpose. For example, > default: > printk(KERN_WARNING "%s: Unrecognized name %d\n", > __func__, name); But many funtions in mm/memcontrol.c use BUG(), if the branch is not present. Regards, Wanpeng Li > >Thanks, >Gavin > >> } >> >> return 0; >>-- >>1.7.5.4 >> >>-- >>To unsubscribe, send a message with 'unsubscribe linux-mm' in >>the body to majordomo@kvack.org. For more info on Linux MM, >>see: http://www.linux-mm.org/ . >>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> >> > >-- >To unsubscribe, send a message with 'unsubscribe linux-mm' in >the body to majordomo@kvack.org. For more info on Linux MM, >see: http://www.linux-mm.org/ . >Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mm/memcg: add BUG() to mem_cgroup_reset 2012-07-06 3:44 [PATCH] mm/memcg: add BUG() to mem_cgroup_reset Wanpeng Li 2012-07-06 5:19 ` Gavin Shan @ 2012-07-06 8:22 ` Johannes Weiner 2012-07-06 8:44 ` Wanpeng Li 1 sibling, 1 reply; 5+ messages in thread From: Johannes Weiner @ 2012-07-06 8:22 UTC (permalink / raw) To: Wanpeng Li Cc: Andrew Morton, Michal Hocko, KAMEZAWA Hiroyuki, cgroups, linux-mm, linux-kernel On Fri, Jul 06, 2012 at 11:44:57AM +0800, Wanpeng Li wrote: > From: Wanpeng Li <liwp@linux.vnet.ibm.com> > > Branch in mem_cgroup_reset only can be RES_MAX_USAGE, RES_FAILCNT. And nobody is passing anything else. Which is easy to prove as this is a private function. And there wouldn't even be any harm passing something else. Please don't add stuff like this. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mm/memcg: add BUG() to mem_cgroup_reset 2012-07-06 8:22 ` Johannes Weiner @ 2012-07-06 8:44 ` Wanpeng Li 0 siblings, 0 replies; 5+ messages in thread From: Wanpeng Li @ 2012-07-06 8:44 UTC (permalink / raw) To: Johannes Weiner Cc: Andrew Morton, Michal Hocko, KAMEZAWA Hiroyuki, cgroups, linux-mm, linux-kernel, Wanpeng Li On Fri, Jul 06, 2012 at 10:22:42AM +0200, Johannes Weiner wrote: >On Fri, Jul 06, 2012 at 11:44:57AM +0800, Wanpeng Li wrote: >> From: Wanpeng Li <liwp@linux.vnet.ibm.com> >> >> Branch in mem_cgroup_reset only can be RES_MAX_USAGE, RES_FAILCNT. > >And nobody is passing anything else. Which is easy to prove as this >is a private function. And there wouldn't even be any harm passing >something else. Please don't add stuff like this. Ok, thank you for your comment. I also have another two patches, title: clarify type in memory cgroups return -EBUSY when oom-kill-disable modified and memcg use_hierarchy, has children Hopefully, you can review. Thank you Johannes! :-) Regards, Wanpeng Li -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-07-06 8:44 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-07-06 3:44 [PATCH] mm/memcg: add BUG() to mem_cgroup_reset Wanpeng Li 2012-07-06 5:19 ` Gavin Shan 2012-07-06 5:37 ` Wanpeng Li 2012-07-06 8:22 ` Johannes Weiner 2012-07-06 8:44 ` Wanpeng Li
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).