[PATCH v2] mm/buddy: more comments for show_free_areas()

[PATCH v2] mm/buddy: more comments for show_free_areas()

[Gavin Shan]

The initial idea comes from Cong Wang. We're running out of memory
while calling function show_free_areas(). So it would be unsafe
to allocate more memory from either stack or heap. The patche adds
more comments to address that.

Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
---
 mm/page_alloc.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 4403009..280c13b 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -2762,6 +2762,9 @@ out:
  * memory on each free list with the exception of the first item on the list.
  * Suppresses nodes that are not allowed by current's cpuset if
  * SHOW_MEM_FILTER_NODES is passed.
+ *
+ * We're running out of memory while calling the function. So don't allocate
+ * more memory from either stack or heap.
  */
 void show_free_areas(unsigned int filter)
 {
-- 
1.7.9.5

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH v2] mm/buddy: more comments for show_free_areas()

[Cong Wang]

On Fri, Jul 6, 2012 at 1:51 PM, Gavin Shan <shangw@linux.vnet.ibm.com> wrote:
> The initial idea comes from Cong Wang. We're running out of memory
> while calling function show_free_areas(). So it would be unsafe
> to allocate more memory from either stack or heap. The patche adds
> more comments to address that.
>

Looks good to me,

Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>

Thanks.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH v2] mm/buddy: more comments for show_free_areas()

[David Rientjes]

On Fri, 6 Jul 2012, Cong Wang wrote:

> > The initial idea comes from Cong Wang. We're running out of memory
> > while calling function show_free_areas(). So it would be unsafe
> > to allocate more memory from either stack or heap. The patche adds
> > more comments to address that.
> >
> 
> Looks good to me,
> 
> Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>
> 

Nack, please see my response to the first version.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>