From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx118.postini.com [74.125.245.118]) by kanga.kvack.org (Postfix) with SMTP id 7CCA06B0069 for ; Mon, 9 Jul 2012 21:13:08 -0400 (EDT) Received: by pbbrp2 with SMTP id rp2so24326663pbb.14 for ; Mon, 09 Jul 2012 18:13:07 -0700 (PDT) From: Wanpeng Li Subject: [PATCH v2] mm/hugetlb: fix error code in hugetlbfs_alloc_inode Date: Tue, 10 Jul 2012 09:12:54 +0800 Message-Id: <1341882774-4772-1-git-send-email-liwp.linux@gmail.com> Sender: owner-linux-mm@kvack.org List-ID: To: linux-mm@kvack.org Cc: Andrew Morton , William Irwin , linux-kernel@vger.kernel.org, Wanpeng Li From: Wanpeng Li Changelog: *v2 change -ENOMEM to ERR_PTR(-ENOMEM); When kmem_cache_alloc fails alloc slab object from hugetlbfs_inode_cachep, return -ENOMEM in usual. But hugetlbfs_alloc_inode implementation has inconsitency with it and returns NULL. Fix it to return -ENOMEM. Signed-off-by: Wanpeng Li --- fs/hugetlbfs/inode.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c index c4b85d0..79a0f33 100644 --- a/fs/hugetlbfs/inode.c +++ b/fs/hugetlbfs/inode.c @@ -696,7 +696,7 @@ static struct inode *hugetlbfs_alloc_inode(struct super_block *sb) p = kmem_cache_alloc(hugetlbfs_inode_cachep, GFP_KERNEL); if (unlikely(!p)) { hugetlbfs_inc_free_inodes(sbinfo); - return NULL; + return ERR_PTR(-ENOMEM); } return &p->vfs_inode; } -- 1.7.5.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org