From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx149.postini.com [74.125.245.149]) by kanga.kvack.org (Postfix) with SMTP id 0BC9F6B005A for ; Mon, 16 Jul 2012 12:16:16 -0400 (EDT) Received: by pbbrp2 with SMTP id rp2so12405653pbb.14 for ; Mon, 16 Jul 2012 09:16:16 -0700 (PDT) From: Joonsoo Kim Subject: [PATCH 2/3] mm: fix possible incorrect return value of migrate_pages() syscall Date: Tue, 17 Jul 2012 01:14:31 +0900 Message-Id: <1342455272-32703-2-git-send-email-js1304@gmail.com> In-Reply-To: <1342455272-32703-1-git-send-email-js1304@gmail.com> References: <1342455272-32703-1-git-send-email-js1304@gmail.com> Sender: owner-linux-mm@kvack.org List-ID: To: akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Joonsoo Kim , Sasha Levin , Christoph Lameter do_migrate_pages() can return the number of pages not migrated. Because migrate_pages() syscall return this value directly, migrate_pages() syscall may return the number of pages not migrated. In fail case in migrate_pages() syscall, we should return error value. So change err to -EIO Additionally, Correct comment above do_migrate_pages() Signed-off-by: Joonsoo Kim Cc: Sasha Levin Cc: Christoph Lameter diff --git a/mm/mempolicy.c b/mm/mempolicy.c index 1d771e4..f7df271 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -948,7 +948,7 @@ static int migrate_to_node(struct mm_struct *mm, int source, int dest, * Move pages between the two nodesets so as to preserve the physical * layout as much as possible. * - * Returns the number of page that could not be moved. + * Returns error or the number of pages not migrated. */ int do_migrate_pages(struct mm_struct *mm, const nodemask_t *from, const nodemask_t *to, int flags) @@ -1382,6 +1382,8 @@ SYSCALL_DEFINE4(migrate_pages, pid_t, pid, unsigned long, maxnode, err = do_migrate_pages(mm, old, new, capable(CAP_SYS_NICE) ? MPOL_MF_MOVE_ALL : MPOL_MF_MOVE); + if (err > 0) + err = -EIO; mmput(mm); out: -- 1.7.9.5 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org