From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx162.postini.com [74.125.245.162]) by kanga.kvack.org (Postfix) with SMTP id 58A796B004D for ; Mon, 16 Jul 2012 13:16:08 -0400 (EDT) Received: by yenr5 with SMTP id r5so6293951yen.14 for ; Mon, 16 Jul 2012 10:16:07 -0700 (PDT) From: Joonsoo Kim Subject: [PATCH 4] mm: fix possible incorrect return value of move_pages() syscall Date: Tue, 17 Jul 2012 02:14:49 +0900 Message-Id: <1342458889-19090-1-git-send-email-js1304@gmail.com> In-Reply-To: <1342455272-32703-1-git-send-email-js1304@gmail.com> References: <1342455272-32703-1-git-send-email-js1304@gmail.com> Sender: owner-linux-mm@kvack.org List-ID: To: akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Joonsoo Kim , Brice Goglin , Christoph Lameter , Minchan Kim move_pages() syscall may return success in case that do_move_page_to_node_array return positive value which means migration failed. This patch changes return value of do_move_page_to_node_array for not returning positive value. It can fix the problem. Signed-off-by: Joonsoo Kim Cc: Brice Goglin Cc: Christoph Lameter Cc: Minchan Kim diff --git a/mm/migrate.c b/mm/migrate.c index 294d52a..adabaf4 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -1171,7 +1171,7 @@ set_status: } up_read(&mm->mmap_sem); - return err; + return err > 0 ? -EIO : err; } /* -- 1.7.9.5 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org