From: David Woodhouse <dwmw2@infradead.org>
To: Michel Lespinasse <walken@google.com>
Cc: aarcange@redhat.com, riel@redhat.com, peterz@infradead.org,
daniel.santos@pobox.com, axboe@kernel.dk, ebiederm@xmission.com,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org
Subject: Re: [PATCH] rbtree: fix jffs2 build issue due to renamed __rb_parent_color field
Date: Wed, 18 Jul 2012 12:40:35 +0100 [thread overview]
Message-ID: <1342611635.25411.83.camel@shinybook.infradead.org> (raw)
In-Reply-To: <20120718113135.GB32698@google.com>
[-- Attachment #1: Type: text/plain, Size: 582 bytes --]
On Wed, 2012-07-18 at 04:31 -0700, Michel Lespinasse wrote:
> Fix this and add a comment explaining why this direct use is safe
> here.
Note that there was already a comment which was *intended* to have that
effect, right before the assignment:
/* Colour doesn't matter now. Only the parent pointer. */
If you're going to make that comment redundant, you might as well remove
it. And you might as well say that the trees are being *destroyed*
(consumed) at this point, rather than just that there will be no further
insert or erase operations.
--
dwmw2
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 6171 bytes --]
next prev parent reply other threads:[~2012-07-18 11:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 11:31 [PATCH] rbtree: fix jffs2 build issue due to renamed __rb_parent_color field Michel Lespinasse
2012-07-18 11:40 ` David Woodhouse [this message]
2012-07-18 15:16 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342611635.25411.83.camel@shinybook.infradead.org \
--to=dwmw2@infradead.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=daniel.santos@pobox.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).