From: Joe Perches <joe@perches.com>
To: Michel Lespinasse <walken@google.com>
Cc: riel@redhat.com, peterz@infradead.org, daniel.santos@pobox.com,
aarcange@redhat.com, dwmw2@infradead.org,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org
Subject: Re: [PATCH v2 9/9] rbtree: remove prior augmented rbtree implementation
Date: Thu, 02 Aug 2012 15:41:13 -0700 [thread overview]
Message-ID: <1343947273.10710.4.camel@joe2Laptop> (raw)
In-Reply-To: <1343946858-8170-10-git-send-email-walken@google.com>
On Thu, 2012-08-02 at 15:34 -0700, Michel Lespinasse wrote:
> convert arch/x86/mm/pat_rbtree.c to the proposed augmented rbtree api
> and remove the old augmented rbtree implementation.
style trivia:
> +static u64 compute_subtree_max_end(struct memtype *data)
> {
> - struct memtype *data;
> - u64 max_end, child_max_end;
> -
> - if (!node)
> - return;
> -
> - data = container_of(node, struct memtype, rb);
> - max_end = data->end;
> + u64 max_end = data->end, child_max_end;
>
> - child_max_end = get_subtree_max_end(node->rb_right);
> + child_max_end = get_subtree_max_end(data->rb.rb_right);
I think this reads better as:
u64 max_end = data->end;
u64 child_max_end = get_subtree_max_end(node->rb.rb_right);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-08-02 22:41 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-02 22:34 [PATCH v2 0/9] faster augmented rbtree interface Michel Lespinasse
2012-08-02 22:34 ` [PATCH v2 1/9] rbtree test: fix sparse warning about 64-bit constant Michel Lespinasse
2012-08-05 20:47 ` Rik van Riel
2012-08-02 22:34 ` [PATCH v2 2/9] rbtree: optimize fetching of sibling node Michel Lespinasse
2012-08-05 23:20 ` Rik van Riel
2012-08-06 14:23 ` Peter Zijlstra
2012-08-06 20:46 ` Michel Lespinasse
2012-08-02 22:34 ` [PATCH v2 3/9] rbtree: add __rb_change_child() helper function Michel Lespinasse
2012-08-06 1:00 ` Rik van Riel
2012-08-06 14:22 ` Peter Zijlstra
2012-08-07 0:04 ` Michel Lespinasse
2012-08-02 22:34 ` [PATCH v2 4/9] rbtree: place easiest case first in rb_erase() Michel Lespinasse
2012-08-06 1:13 ` Rik van Riel
2012-08-02 22:34 ` [PATCH v2 5/9] rbtree: handle 1-child recoloring in rb_erase() instead of rb_erase_color() Michel Lespinasse
2012-08-06 1:27 ` Rik van Riel
2012-08-02 22:34 ` [PATCH v2 6/9] rbtree: low level optimizations in rb_erase() Michel Lespinasse
2012-08-06 1:41 ` Rik van Riel
2012-08-06 14:21 ` Peter Zijlstra
2012-08-06 20:50 ` Michel Lespinasse
2012-08-06 20:58 ` Peter Zijlstra
2012-08-06 21:20 ` Michel Lespinasse
2012-08-06 21:21 ` Michel Lespinasse
2012-08-02 22:34 ` [PATCH v2 7/9] rbtree: augmented rbtree test Michel Lespinasse
2012-08-06 2:11 ` Rik van Riel
2012-08-02 22:34 ` [PATCH v2 8/9] rbtree: faster augmented rbtree manipulation Michel Lespinasse
2012-08-06 2:12 ` Rik van Riel
2012-08-06 14:17 ` Peter Zijlstra
2012-08-06 15:38 ` Peter Zijlstra
2012-08-06 21:55 ` Michel Lespinasse
2012-08-07 7:12 ` [PATCH] rbtree: add RB_DECLARE_CALLBACKS() macro Michel Lespinasse
2012-08-06 14:25 ` [PATCH v2 8/9] rbtree: faster augmented rbtree manipulation Peter Zijlstra
2012-08-06 21:34 ` Michel Lespinasse
2012-08-06 21:36 ` Peter Zijlstra
2012-08-06 14:29 ` Peter Zijlstra
2012-08-06 21:38 ` Michel Lespinasse
2012-08-02 22:34 ` [PATCH v2 9/9] rbtree: remove prior augmented rbtree implementation Michel Lespinasse
2012-08-02 22:41 ` Joe Perches [this message]
2012-08-06 2:13 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343947273.10710.4.camel@joe2Laptop \
--to=joe@perches.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=daniel.santos@pobox.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).