From: Sasha Levin <levinsasha928@gmail.com>
To: torvalds@linux-foundation.org
Cc: tj@kernel.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
paul.gortmaker@windriver.com, davem@davemloft.net,
rostedt@goodmis.org, mingo@elte.hu, ebiederm@xmission.com,
aarcange@redhat.com, ericvh@gmail.com, netdev@vger.kernel.org,
josh@joshtriplett.org, eric.dumazet@gmail.com,
mathieu.desnoyers@efficios.com,
Sasha Levin <levinsasha928@gmail.com>
Subject: [RFC v3 0/7] generic hashtable implementation
Date: Tue, 7 Aug 2012 02:45:09 +0200 [thread overview]
Message-ID: <1344300317-23189-1-git-send-email-levinsasha928@gmail.com> (raw)
There are quite a few places in the kernel which implement a hashtable
in a very similar way. Instead of having implementations of a hashtable
all over the kernel, we can re-use the code.
This patch series introduces a very simple hashtable implementation, and
modifies three (random) modules to use it. I've limited it to 3 only
so that it would be easy to review and modify, and to show that even
at this number we already eliminate a big amount of duplicated code.
If this basic hashtable looks ok, future code will include:
- RCU support
- Self locking (list_bl?)
- Converting more code to use the hashtable
Changes in V3:
- Address review comments by Tejun Heo, Josh Triplett, Eric Beiderman,
Mathieu Desnoyers, Eric Dumazet and Linus Torvalds.
- Removed hash_get due to being too Gandalf.
- Rewrote the user namespaces hash implementation.
- Hashtable went back to being a simple array of buckets, but without any
of the macro tricks to get the size automatically.
- Optimize hasing if key is 32 bits long.
Changes in V2:
- Address review comments by Tejun Heo, Josh Triplett and Eric Beiderman (Thanks all!).
- Rebase on top of latest master.
- Convert more places to use the hashtable. Hopefully it will trigger more reviews by
touching more subsystems.
Sasha Levin (7):
hashtable: introduce a small and naive hashtable
user_ns: use new hashtable implementation
mm,ksm: use new hashtable implementation
workqueue: use new hashtable implementation
mm/huge_memory: use new hashtable implementation
tracepoint: use new hashtable implementation
net,9p: use new hashtable implementation
include/linux/hashtable.h | 82 +++++++++++++++++++++++++++++++++++++++++
kernel/tracepoint.c | 26 +++++--------
kernel/user.c | 35 ++++++++----------
kernel/workqueue.c | 89 +++++++++------------------------------------
mm/huge_memory.c | 56 +++++++---------------------
mm/ksm.c | 31 +++++++---------
net/9p/error.c | 21 +++++------
7 files changed, 162 insertions(+), 178 deletions(-)
create mode 100644 include/linux/hashtable.h
--
1.7.8.6
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2012-08-07 0:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 0:45 Sasha Levin [this message]
2012-08-07 0:45 ` [RFC v3 1/7] hashtable: introduce a small and naive hashtable Sasha Levin
2012-08-07 1:19 ` Joe Perches
2012-08-07 1:48 ` Li Wei
2012-08-07 1:54 ` Sasha Levin
2012-08-07 2:55 ` Josh Triplett
2012-08-07 9:49 ` Sasha Levin
2012-08-07 0:45 ` [RFC v3 2/7] user_ns: use new hashtable implementation Sasha Levin
2012-08-07 0:45 ` [RFC v3 3/7] mm,ksm: " Sasha Levin
2012-08-07 0:45 ` [RFC v3 4/7] workqueue: " Sasha Levin
2012-08-07 0:45 ` Sasha Levin
2012-08-07 1:19 ` Joe Perches
2012-08-07 0:45 ` [RFC v3 5/7] mm/huge_memory: " Sasha Levin
2012-08-07 0:45 ` [RFC v3 6/7] tracepoint: " Sasha Levin
2012-08-07 0:45 ` [RFC v3 7/7] net,9p: " Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344300317-23189-1-git-send-email-levinsasha928@gmail.com \
--to=levinsasha928@gmail.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=ericvh@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).