From: Minchan Kim <minchan@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Nitin Gupta <ngupta@vflare.org>,
Seth Jennings <sjenning@linux.vnet.ibm.com>,
Dan Magenheimer <dan.magenheimer@oracle.com>,
Konrad Rzeszutek Wilk <konrad@darnok.org>,
Minchan Kim <minchan@kernel.org>
Subject: [PATCH 1/7] zsmalloc: s/firstpage/page in new copy map funcs
Date: Wed, 8 Aug 2012 15:12:14 +0900 [thread overview]
Message-ID: <1344406340-14128-2-git-send-email-minchan@kernel.org> (raw)
In-Reply-To: <1344406340-14128-1-git-send-email-minchan@kernel.org>
From: Seth Jennings <sjenning@linux.vnet.ibm.com>
firstpage already has precedent and meaning the first page
of a zspage. In the case of the copy mapping functions,
it is the first of a pair of pages needing to be mapped.
This patch just renames the firstpage argument to "page" to
avoid confusion.
Signed-off-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
Signed-off-by: Minchan Kim <minchan@kernel.org>
---
drivers/staging/zsmalloc/zsmalloc-main.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/zsmalloc/zsmalloc-main.c b/drivers/staging/zsmalloc/zsmalloc-main.c
index 8b0bcb6..3c83c65 100644
--- a/drivers/staging/zsmalloc/zsmalloc-main.c
+++ b/drivers/staging/zsmalloc/zsmalloc-main.c
@@ -470,15 +470,15 @@ static struct page *find_get_zspage(struct size_class *class)
return page;
}
-static void zs_copy_map_object(char *buf, struct page *firstpage,
+static void zs_copy_map_object(char *buf, struct page *page,
int off, int size)
{
struct page *pages[2];
int sizes[2];
void *addr;
- pages[0] = firstpage;
- pages[1] = get_next_page(firstpage);
+ pages[0] = page;
+ pages[1] = get_next_page(page);
BUG_ON(!pages[1]);
sizes[0] = PAGE_SIZE - off;
@@ -493,15 +493,15 @@ static void zs_copy_map_object(char *buf, struct page *firstpage,
kunmap_atomic(addr);
}
-static void zs_copy_unmap_object(char *buf, struct page *firstpage,
+static void zs_copy_unmap_object(char *buf, struct page *page,
int off, int size)
{
struct page *pages[2];
int sizes[2];
void *addr;
- pages[0] = firstpage;
- pages[1] = get_next_page(firstpage);
+ pages[0] = page;
+ pages[1] = get_next_page(page);
BUG_ON(!pages[1]);
sizes[0] = PAGE_SIZE - off;
--
1.7.9.5
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-08-08 6:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 6:12 [PATCH 0/7] zram/zsmalloc promotion Minchan Kim
2012-08-08 6:12 ` Minchan Kim [this message]
2012-08-08 6:12 ` [PATCH 2/7] zsmalloc: prevent mappping in interrupt context Minchan Kim
2012-08-08 6:12 ` [PATCH 3/7] zsmalloc: add page table mapping method Minchan Kim
2012-08-08 6:12 ` [PATCH 4/7] zsmalloc: collapse internal .h into .c Minchan Kim
2012-08-08 6:12 ` [PATCH 5/7] zsmalloc: promote to mm/ Minchan Kim
2012-08-08 6:12 ` [PATCH 6/7] zram: promote zram from staging Minchan Kim
2012-08-08 6:12 ` [PATCH 7/7] zram: select ZSMALLOC when ZRAM is configured Minchan Kim
2012-08-08 17:35 ` [PATCH 0/7] zram/zsmalloc promotion Nitin Gupta
2012-08-10 1:15 ` Konrad Rzeszutek Wilk
2012-08-14 2:35 ` Greg Kroah-Hartman
2012-08-14 5:36 ` Nitin Gupta
2012-08-14 6:20 ` Minchan Kim
2012-08-14 17:39 ` Seth Jennings
2012-08-15 9:42 ` Konrad Rzeszutek Wilk
2012-08-15 15:23 ` Dan Magenheimer
2012-08-14 6:22 ` Minchan Kim
2012-08-14 13:21 ` Konrad Rzeszutek Wilk
2012-08-17 5:47 ` Nitin Gupta
2012-08-21 0:56 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344406340-14128-2-git-send-email-minchan@kernel.org \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dan.magenheimer@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=konrad@darnok.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ngupta@vflare.org \
--cc=sjenning@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).