From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx184.postini.com [74.125.245.184]) by kanga.kvack.org (Postfix) with SMTP id 9EC546B005D for ; Wed, 15 Aug 2012 11:04:00 -0400 (EDT) Received: by ggnf4 with SMTP id f4so2285277ggn.14 for ; Wed, 15 Aug 2012 08:03:59 -0700 (PDT) From: Joonsoo Kim Subject: [PATCH 1/2] slub: reduce failure of this_cpu_cmpxchg in put_cpu_partial() after unfreezing Date: Thu, 16 Aug 2012 00:02:39 +0900 Message-Id: <1345042960-6287-1-git-send-email-js1304@gmail.com> Sender: owner-linux-mm@kvack.org List-ID: To: Pekka Enberg Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Joonsoo Kim , Christoph Lameter , David Rientjes In current implementation, after unfreezing, we doesn't touch oldpage, so it remain 'NOT NULL'. When we call this_cpu_cmpxchg() with this old oldpage, this_cpu_cmpxchg() is mostly be failed. We can change value of oldpage to NULL after unfreezing, because unfreeze_partial() ensure that all the cpu partial slabs is removed from cpu partial list. In this time, we could expect that this_cpu_cmpxchg is mostly succeed. Signed-off-by: Joonsoo Kim Cc: Christoph Lameter Cc: David Rientjes Acked-by: Christoph Lameter --- Hello, Pekka. These two patches get "Acked-by: Christoph Lameter ", but, I don't hear any answer from U. Could you review these, please? Thanks! diff --git a/mm/slub.c b/mm/slub.c index e517d43..ca778e5 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -1952,6 +1952,7 @@ int put_cpu_partial(struct kmem_cache *s, struct page *page, int drain) local_irq_save(flags); unfreeze_partials(s); local_irq_restore(flags); + oldpage = NULL; pobjects = 0; pages = 0; stat(s, CPU_PARTIAL_DRAIN); -- 1.7.9.5 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org