linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: wency@cn.fujitsu.com
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: rientjes@google.com, liuj97@gmail.com, len.brown@intel.com,
	benh@kernel.crashing.org, paulus@samba.org,
	minchan.kim@gmail.com, akpm@linux-foundation.org,
	kosaki.motohiro@jp.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com,
	Wen Congyang <wency@cn.fujitsu.com>
Subject: [PATCH 2/4] memory-hotplug: add node_device_release
Date: Thu, 27 Sep 2012 13:45:03 +0800	[thread overview]
Message-ID: <1348724705-23779-3-git-send-email-wency@cn.fujitsu.com> (raw)
In-Reply-To: <1348724705-23779-1-git-send-email-wency@cn.fujitsu.com>

From: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>

When calling unregister_node(), the function shows following message at
device_release().

Device 'node2' does not have a release() function, it is broken and must be
fixed.

So the patch implements node_device_release()

CC: David Rientjes <rientjes@google.com>
CC: Jiang Liu <liuj97@gmail.com>
CC: Len Brown <len.brown@intel.com>
CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
CC: Paul Mackerras <paulus@samba.org>
Cc: Minchan Kim <minchan.kim@gmail.com>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
---
 drivers/base/node.c |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/drivers/base/node.c b/drivers/base/node.c
index af1a177..07523fb 100644
--- a/drivers/base/node.c
+++ b/drivers/base/node.c
@@ -252,6 +252,16 @@ static inline void hugetlb_register_node(struct node *node) {}
 static inline void hugetlb_unregister_node(struct node *node) {}
 #endif
 
+static void node_device_release(struct device *dev)
+{
+	struct node *node_dev = to_node(dev);
+
+#if defined(CONFIG_MEMORY_HOTPLUG_SPARSE) && defined(CONFIG_HUGETLBFS)
+	flush_work(&node_dev->node_work);
+#endif
+
+	memset(node_dev, 0, sizeof(struct node));
+}
 
 /*
  * register_node - Setup a sysfs device for a node.
@@ -265,6 +275,7 @@ int register_node(struct node *node, int num, struct node *parent)
 
 	node->dev.id = num;
 	node->dev.bus = &node_subsys;
+	node->dev.release = node_device_release;
 	error = device_register(&node->dev);
 
 	if (!error){
-- 
1.7.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2012-09-27  5:39 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-27  5:45 [PATCH 0/4] bugfix for memory hotplug wency
2012-09-27  5:45 ` [PATCH 1/4] memory-hotplug: add memory_block_release wency
2012-09-27 10:20   ` Ni zhan Chen
2012-09-28  0:24     ` Yasuaki Ishimatsu
2012-09-28  1:35       ` KOSAKI Motohiro
2012-09-28  3:45         ` Yasuaki Ishimatsu
2012-09-28  6:04           ` Ni zhan Chen
2012-09-28  6:11             ` Yasuaki Ishimatsu
2012-09-28  6:14           ` Ni zhan Chen
2012-09-28 22:30           ` KOSAKI Motohiro
2012-09-27 20:11   ` KOSAKI Motohiro
2012-09-27  5:45 ` wency [this message]
2012-09-27 10:38   ` [PATCH 2/4] memory-hotplug: add node_device_release Ni zhan Chen
2012-09-27 20:13   ` KOSAKI Motohiro
2012-09-28  0:07     ` Yasuaki Ishimatsu
2012-09-28  1:13       ` KOSAKI Motohiro
2012-09-28  1:30         ` Yasuaki Ishimatsu
2012-09-28  1:37           ` KOSAKI Motohiro
2012-09-28  9:55             ` Yasuaki Ishimatsu
2012-09-28 22:19               ` KOSAKI Motohiro
2012-10-01  6:54                 ` Yasuaki Ishimatsu
2012-10-01 18:12                   ` KOSAKI Motohiro
2012-10-05  1:00                     ` Yasuaki Ishimatsu
2012-10-05 18:39                       ` KOSAKI Motohiro
2012-09-27  5:45 ` [PATCH 3/4] memory-hotplug: clear hwpoisoned flag when onlining pages wency
2012-09-27 12:27   ` Ni zhan Chen
2012-09-27 20:17   ` KOSAKI Motohiro
2012-09-28  1:53     ` Wen Congyang
2012-09-27  5:45 ` [PATCH 4/4] memory-hotplug: auto offline page_cgroup when onlining memory block failed wency
2012-09-27 12:44   ` Ni zhan Chen
2012-09-27 20:19   ` KOSAKI Motohiro
2012-09-27 21:18 ` [PATCH 0/4] bugfix for memory hotplug Andrew Morton
2012-09-29  2:31 ` Ni zhan Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1348724705-23779-3-git-send-email-wency@cn.fujitsu.com \
    --to=wency@cn.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=isimatu.yasuaki@jp.fujitsu.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liuj97@gmail.com \
    --cc=minchan.kim@gmail.com \
    --cc=paulus@samba.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).