From: Johannes Berg <johannes@sipsolutions.net>
To: JoonSoo Kim <js1304@gmail.com>
Cc: Christoph Lameter <cl@linux-foundation.org>,
Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
linux-mm@kvack.org
Subject: Re: slab vs. slub kmem cache name inconsistency
Date: Tue, 02 Oct 2012 13:08:59 +0200 [thread overview]
Message-ID: <1349176139.10698.15.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CAAmzW4OvWVfHhqs3puzArvVoNp4ZopZXdc38RVmFBkMd_LjNWA@mail.gmail.com> (sfid-20121002_130550_956053_D126E2C4)
Hi,
> > I just noticed that slub's kmem_cache_create() will kstrdup() the name,
> > while slab doesn't. That's a little confusing, since when you look at
> > slub you can easily get away with passing a string you built on the
> > stack, while that will then lead to very strange results (and possibly
> > crashes?) with slab.
>
> As far as I know, this issue is already fixed. However, fix for this
> is not merged into mainline yet.
> You can find the fix in common_for_cgroups branch of Pekka's git tree.
>
> git://git.kernel.org/pub/scm/linux/kernel/git/penberg/linux.git
> slab/common-for-cgroups
Cool, yes, we have a commit there which addresses this:
http://git.kernel.org/?p=linux/kernel/git/penberg/linux.git;a=commit;h=db265eca77000c5dafc5608975afe8dafb2a02d5
Thanks!
johannes
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-10-02 11:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-02 9:40 slab vs. slub kmem cache name inconsistency Johannes Berg
2012-10-02 11:05 ` JoonSoo Kim
2012-10-02 11:08 ` Johannes Berg [this message]
2012-10-02 14:43 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349176139.10698.15.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=cl@linux-foundation.org \
--cc=js1304@gmail.com \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).