linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: linux-mm@kvack.org
Cc: Will Deacon <will.deacon@arm.com>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>,
	Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <peterz@infradead.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] numa, mm: drop redundant check in do_huge_pmd_numa_page()
Date: Fri, 26 Oct 2012 15:54:34 +0300	[thread overview]
Message-ID: <1351256077-1594-1-git-send-email-kirill.shutemov@linux.intel.com> (raw)

From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>

We check if the pmd entry is the same as on pmd_trans_huge() in
handle_mm_fault(). That's enough.

Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
---
 mm/huge_memory.c |    6 ------
 1 file changed, 6 deletions(-)

diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 3c14a96..9bb2c23 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -758,12 +758,6 @@ void do_huge_pmd_numa_page(struct mm_struct *mm, struct vm_area_struct *vma,
 	if (unlikely(!pmd_same(*pmd, entry)))
 		goto unlock;
 
-	if (unlikely(pmd_trans_splitting(entry))) {
-		spin_unlock(&mm->page_table_lock);
-		wait_split_huge_page(vma->anon_vma, pmd);
-		return;
-	}
-
 	page = pmd_page(entry);
 	if (page) {
 		VM_BUG_ON(!PageCompound(page) || !PageHead(page));
-- 
1.7.10.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2012-10-26 12:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-26 12:54 Kirill A. Shutemov [this message]
2012-10-26 12:54 ` [PATCH 2/2] numa, mm: consolidate error path in do_huge_pmd_numa_page() Kirill A. Shutemov
2012-10-26 13:10   ` Peter Zijlstra
2012-10-26 13:08 ` [PATCH 1/2] numa, mm: drop redundant check " Peter Zijlstra
2012-10-26 13:41   ` Kirill A. Shutemov
2012-10-26 13:43     ` Peter Zijlstra
2012-10-26 13:57       ` Kirill A. Shutemov
2012-10-26 14:07         ` Peter Zijlstra
2012-10-26 14:34           ` Kirill A. Shutemov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1351256077-1594-1-git-send-email-kirill.shutemov@linux.intel.com \
    --to=kirill.shutemov@linux.intel.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=will.deacon@arm.com \
    --cc=xiaoguangrong@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).