From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx169.postini.com [74.125.245.169]) by kanga.kvack.org (Postfix) with SMTP id 2F9CF6B0072 for ; Fri, 26 Oct 2012 09:08:50 -0400 (EDT) Message-ID: <1351256885.16863.62.camel@twins> Subject: Re: [PATCH 1/2] numa, mm: drop redundant check in do_huge_pmd_numa_page() From: Peter Zijlstra Date: Fri, 26 Oct 2012 15:08:05 +0200 In-Reply-To: <1351256077-1594-1-git-send-email-kirill.shutemov@linux.intel.com> References: <1351256077-1594-1-git-send-email-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Sender: owner-linux-mm@kvack.org List-ID: To: "Kirill A. Shutemov" Cc: linux-mm@kvack.org, Will Deacon , Andrew Morton , Andrea Arcangeli , Xiao Guangrong , Ingo Molnar , linux-kernel@vger.kernel.org On Fri, 2012-10-26 at 15:54 +0300, Kirill A. Shutemov wrote: > From: "Kirill A. Shutemov" >=20 > We check if the pmd entry is the same as on pmd_trans_huge() in > handle_mm_fault(). That's enough. >=20 > Signed-off-by: Kirill A. Shutemov Ah indeed, Will mentioned something like this on IRC as well, I hadn't gotten around to looking at it -- now have, thanks! Acked-by: Peter Zijlstra That said, where in handle_mm_fault() do we wait for a split to complete? We have a pmd_trans_huge() && !pmd_trans_splitting(), so a fault on a currently splitting pmd will fall through. Is it the return from the fault on unlikely(pmd_trans_huge()) ? I'm probably missing something obvious.. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org