From: Sasha Levin <levinsasha928@gmail.com>
To: torvalds@linux-foundation.org
Cc: tj@kernel.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
paul.gortmaker@windriver.com, davem@davemloft.net,
rostedt@goodmis.org, mingo@elte.hu, ebiederm@xmission.com,
aarcange@redhat.com, ericvh@gmail.com, netdev@vger.kernel.org,
josh@joshtriplett.org, eric.dumazet@gmail.com,
mathieu.desnoyers@efficios.com, axboe@kernel.dk, agk@redhat.com,
dm-devel@redhat.com, neilb@suse.de, ccaulfie@redhat.com,
teigland@redhat.com, Trond.Myklebust@netapp.com,
bfields@fieldses.org, fweisbec@gmail.com, jesse@nicira.com,
venkat.x.venkatsubra@oracle.com, ejt@redhat.com,
snitzer@redhat.com, edumazet@google.com,
linux-nfs@vger.kernel.org, dev@openvswitch.org,
rds-devel@oss.oracle.com, lw@cn.fujitsu.com,
Sasha Levin <levinsasha928@gmail.com>
Subject: [PATCH v8 16/16] tracing output: use new hashtable implementation
Date: Tue, 30 Oct 2012 14:46:12 -0400 [thread overview]
Message-ID: <1351622772-16400-16-git-send-email-levinsasha928@gmail.com> (raw)
In-Reply-To: <1351622772-16400-1-git-send-email-levinsasha928@gmail.com>
Switch tracing to use the new hashtable implementation. This reduces the
amount of generic unrelated code in the tracing module.
Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
---
kernel/trace/trace_output.c | 18 ++++++------------
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c
index 123b189..6af4879 100644
--- a/kernel/trace/trace_output.c
+++ b/kernel/trace/trace_output.c
@@ -8,15 +8,15 @@
#include <linux/module.h>
#include <linux/mutex.h>
#include <linux/ftrace.h>
+#include <linux/hashtable.h>
#include "trace_output.h"
-/* must be a power of 2 */
-#define EVENT_HASHSIZE 128
+#define EVENT_HASH_BITS 7
DECLARE_RWSEM(trace_event_mutex);
-static struct hlist_head event_hash[EVENT_HASHSIZE] __read_mostly;
+static DEFINE_HASHTABLE(event_hash, EVENT_HASH_BITS);
static int next_event_type = __TRACE_LAST_TYPE + 1;
@@ -712,11 +712,8 @@ struct trace_event *ftrace_find_event(int type)
{
struct trace_event *event;
struct hlist_node *n;
- unsigned key;
- key = type & (EVENT_HASHSIZE - 1);
-
- hlist_for_each_entry(event, n, &event_hash[key], node) {
+ hash_for_each_possible(event_hash, event, n, node, type) {
if (event->type == type)
return event;
}
@@ -781,7 +778,6 @@ void trace_event_read_unlock(void)
*/
int register_ftrace_event(struct trace_event *event)
{
- unsigned key;
int ret = 0;
down_write(&trace_event_mutex);
@@ -833,9 +829,7 @@ int register_ftrace_event(struct trace_event *event)
if (event->funcs->binary == NULL)
event->funcs->binary = trace_nop_print;
- key = event->type & (EVENT_HASHSIZE - 1);
-
- hlist_add_head(&event->node, &event_hash[key]);
+ hash_add(event_hash, &event->node, event->type);
ret = event->type;
out:
@@ -850,7 +844,7 @@ EXPORT_SYMBOL_GPL(register_ftrace_event);
*/
int __unregister_ftrace_event(struct trace_event *event)
{
- hlist_del(&event->node);
+ hash_del(&event->node);
list_del(&event->list);
return 0;
}
--
1.7.12.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-10-30 18:48 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 18:45 [PATCH v8 01/16] hashtable: introduce a small and naive hashtable Sasha Levin
2012-10-30 18:45 ` [PATCH v8 02/16] userns: use new hashtable implementation Sasha Levin
2012-10-30 18:45 ` [PATCH v8 03/16] mm,ksm: " Sasha Levin
2012-10-30 18:46 ` [PATCH v8 04/16] workqueue: " Sasha Levin
2012-10-30 18:46 ` [PATCH v8 05/16] mm/huge_memory: " Sasha Levin
2012-10-30 18:46 ` [PATCH v8 06/16] tracepoint: " Sasha Levin
2012-10-30 19:20 ` Mathieu Desnoyers
2012-10-30 18:46 ` [PATCH v8 07/16] net,9p: " Sasha Levin
2012-10-30 18:46 ` [PATCH v8 08/16] block,elevator: " Sasha Levin
2012-10-30 18:46 ` [PATCH v8 09/16] SUNRPC/cache: " Sasha Levin
2012-10-30 18:46 ` [PATCH v8 10/16] dlm: " Sasha Levin
2012-10-30 18:46 ` [PATCH v8 11/16] net,l2tp: " Sasha Levin
2012-10-30 18:46 ` [PATCH v8 12/16] dm: " Sasha Levin
2012-10-30 18:46 ` [PATCH v8 13/16] lockd: " Sasha Levin
2012-10-30 18:46 ` [PATCH v8 14/16] net,rds: " Sasha Levin
2012-10-30 18:46 ` [PATCH v8 15/16] openvswitch: " Sasha Levin
2012-10-30 18:46 ` Sasha Levin [this message]
2012-10-30 19:23 ` [PATCH v8 16/16] tracing output: " Steven Rostedt
2012-10-30 19:19 ` [PATCH v8 01/16] hashtable: introduce a small and naive hashtable Mathieu Desnoyers
2012-10-30 21:42 ` Tejun Heo
2012-10-31 0:33 ` Sasha Levin
2012-10-31 0:51 ` Jim Rees
2012-10-31 1:15 ` Sasha Levin
2012-10-31 1:16 ` Steven Rostedt
2012-10-31 1:25 ` Linus Torvalds
2012-10-31 1:36 ` Sasha Levin
2012-10-31 2:23 ` Linus Torvalds
2012-11-02 4:23 ` Sasha Levin
2012-10-31 1:36 ` Steven Rostedt
2012-10-31 2:24 ` Al Viro
2012-10-31 2:48 ` Linus Torvalds
2012-10-31 3:24 ` Al Viro
2012-10-31 3:48 ` Linus Torvalds
2012-10-31 9:46 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351622772-16400-16-git-send-email-levinsasha928@gmail.com \
--to=levinsasha928@gmail.com \
--cc=Trond.Myklebust@netapp.com \
--cc=aarcange@redhat.com \
--cc=agk@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=bfields@fieldses.org \
--cc=ccaulfie@redhat.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=dm-devel@redhat.com \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=ejt@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=ericvh@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jesse@nicira.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=lw@cn.fujitsu.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@elte.hu \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=rds-devel@oss.oracle.com \
--cc=rostedt@goodmis.org \
--cc=snitzer@redhat.com \
--cc=teigland@redhat.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=venkat.x.venkatsubra@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).