From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>,
linux-mm@kvack.org
Cc: Andi Kleen <ak@linux.intel.com>,
"H. Peter Anvin" <hpa@linux.intel.com>,
linux-kernel@vger.kernel.org,
"Kirill A. Shutemov" <kirill@shutemov.name>,
David Rientjes <rientjes@google.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: [PATCH v6 03/12] thp: copy_huge_pmd(): copy huge zero page
Date: Thu, 15 Nov 2012 21:26:53 +0200 [thread overview]
Message-ID: <1353007622-18393-4-git-send-email-kirill.shutemov@linux.intel.com> (raw)
In-Reply-To: <1353007622-18393-1-git-send-email-kirill.shutemov@linux.intel.com>
From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
It's easy to copy huge zero page. Just set destination pmd to huge zero
page.
It's safe to copy huge zero page since we have none yet :-p
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
---
mm/huge_memory.c | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index fc2cada..183127c 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -701,6 +701,18 @@ static inline struct page *alloc_hugepage(int defrag)
}
#endif
+static void set_huge_zero_page(pgtable_t pgtable, struct mm_struct *mm,
+ struct vm_area_struct *vma, unsigned long haddr, pmd_t *pmd)
+{
+ pmd_t entry;
+ entry = pfn_pmd(huge_zero_pfn, vma->vm_page_prot);
+ entry = pmd_wrprotect(entry);
+ entry = pmd_mkhuge(entry);
+ set_pmd_at(mm, haddr, pmd, entry);
+ pgtable_trans_huge_deposit(mm, pgtable);
+ mm->nr_ptes++;
+}
+
int do_huge_pmd_anonymous_page(struct mm_struct *mm, struct vm_area_struct *vma,
unsigned long address, pmd_t *pmd,
unsigned int flags)
@@ -778,6 +790,16 @@ int copy_huge_pmd(struct mm_struct *dst_mm, struct mm_struct *src_mm,
pte_free(dst_mm, pgtable);
goto out_unlock;
}
+ /*
+ * mm->pagetable lock is enough to be sure that huge zero pmd is not
+ * under splitting since we don't split the page itself, only pmd to
+ * a page table.
+ */
+ if (is_huge_zero_pmd(pmd)) {
+ set_huge_zero_page(pgtable, dst_mm, vma, addr, dst_pmd);
+ ret = 0;
+ goto out_unlock;
+ }
if (unlikely(pmd_trans_splitting(pmd))) {
/* split huge page running from under us */
spin_unlock(&src_mm->page_table_lock);
--
1.7.11.7
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-11-15 19:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 19:26 [PATCH v6 00/12] Introduce huge zero page Kirill A. Shutemov
2012-11-15 19:26 ` [PATCH v6 01/12] thp: huge zero page: basic preparation Kirill A. Shutemov
2012-11-15 19:26 ` [PATCH v6 02/12] thp: zap_huge_pmd(): zap huge zero pmd Kirill A. Shutemov
2012-11-15 19:26 ` Kirill A. Shutemov [this message]
2012-11-15 22:32 ` [patch] thp: copy_huge_pmd(): copy huge zero page v6 fix David Rientjes
2012-11-15 19:26 ` [PATCH v6 04/12] thp: do_huge_pmd_wp_page(): handle huge zero page Kirill A. Shutemov
2012-11-15 19:26 ` [PATCH v6 05/12] thp: change_huge_pmd(): keep huge zero page write-protected Kirill A. Shutemov
2012-11-15 19:26 ` [PATCH v6 06/12] thp: change split_huge_page_pmd() interface Kirill A. Shutemov
2012-11-15 19:26 ` [PATCH v6 07/12] thp: implement splitting pmd for huge zero page Kirill A. Shutemov
2012-11-15 19:26 ` [PATCH v6 08/12] thp: setup huge zero page on non-write page fault Kirill A. Shutemov
2012-11-15 19:26 ` [PATCH v6 09/12] thp: lazy huge zero page allocation Kirill A. Shutemov
2012-11-15 19:27 ` [PATCH v6 10/12] thp: implement refcounting for huge zero page Kirill A. Shutemov
2012-11-18 6:23 ` Jaegeuk Hanse
2012-11-19 9:56 ` Kirill A. Shutemov
2012-11-19 10:20 ` Jaegeuk Hanse
2012-11-19 10:23 ` Kirill A. Shutemov
2012-11-19 11:02 ` Jaegeuk Hanse
2012-11-19 11:09 ` Kirill A. Shutemov
2012-11-19 11:29 ` Jaegeuk Hanse
2012-11-15 19:27 ` [PATCH v6 11/12] thp, vmstat: implement HZP_ALLOC and HZP_ALLOC_FAILED events Kirill A. Shutemov
2012-11-15 19:27 ` [PATCH v6 12/12] thp: introduce sysfs knob to disable huge zero page Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353007622-18393-4-git-send-email-kirill.shutemov@linux.intel.com \
--to=kirill.shutemov@linux.intel.com \
--cc=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).