From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx129.postini.com [74.125.245.129]) by kanga.kvack.org (Postfix) with SMTP id 5B99A6B002B for ; Mon, 10 Dec 2012 20:49:04 -0500 (EST) Received: by mail-ia0-f169.google.com with SMTP id r4so6483987iaj.14 for ; Mon, 10 Dec 2012 17:49:03 -0800 (PST) Message-ID: <1355190540.1933.4.camel@kernel.cn.ibm.com> Subject: Re: [PATCH V2] MCE: fix an error of mce_bad_pages statistics From: Simon Jeons Date: Mon, 10 Dec 2012 19:49:00 -0600 In-Reply-To: <20121210153805.GS16230@one.firstfloor.org> References: <50C1AD6D.7010709@huawei.com> <20121207141102.4fda582d.akpm@linux-foundation.org> <20121210083342.GA31670@hacker.(null)> <50C5A62A.6030401@huawei.com> <1355136423.1700.2.camel@kernel.cn.ibm.com> <50C5C4A2.2070002@huawei.com> <20121210153805.GS16230@one.firstfloor.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: owner-linux-mm@kvack.org List-ID: To: Andi Kleen Cc: Xishi Qiu , Wanpeng Li , Andrew Morton , WuJianguo , Liujiang , Vyacheslav.Dubeyko@huawei.com, Borislav Petkov , linux-mm@kvack.org, linux-kernel@vger.kernel.org, wency@cn.fujitsu.com On Mon, 2012-12-10 at 16:38 +0100, Andi Kleen wrote: > > It is another topic, I mean since the page is poisoned, so why not isolate it > > from page buddy alocator in soft_offline_page() rather than in check_new_page(). > > I find soft_offline_page() only migrate the page and mark HWPoison, the poisoned > > page is still managed by page buddy alocator. > > Doing it in check_new_page is the only way if the page is currently > allocated by someone. Since that's not uncommon it's simplest to always > do it this way. Hi Andi, IIUC, soft offlining will isolate and migrate hwpoisoned page, and this page will not be accessed by memory management subsystem until unpoison, correct? -Simon > > -Andi > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org