From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx110.postini.com [74.125.245.110]) by kanga.kvack.org (Postfix) with SMTP id D18096B005A for ; Thu, 13 Dec 2012 00:36:04 -0500 (EST) Received: by mail-pa0-f41.google.com with SMTP id bj3so1201221pad.14 for ; Wed, 12 Dec 2012 21:36:04 -0800 (PST) Message-ID: <1355376960.1567.3.camel@kernel.cn.ibm.com> Subject: Re: [patch 1/8] mm: memcg: only evict file pages when we have plenty From: Simon Jeons Date: Wed, 12 Dec 2012 23:36:00 -0600 In-Reply-To: <50C8FCE0.1060408@redhat.com> References: <1355348620-9382-1-git-send-email-hannes@cmpxchg.org> <1355348620-9382-2-git-send-email-hannes@cmpxchg.org> <50C8FCE0.1060408@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Rik van Riel Cc: Johannes Weiner , Andrew Morton , Michal Hocko , Mel Gorman , Hugh Dickins , linux-mm@kvack.org, linux-kernel@vger.kernel.org On Wed, 2012-12-12 at 16:53 -0500, Rik van Riel wrote: > On 12/12/2012 04:43 PM, Johannes Weiner wrote: > > dc0422c "mm: vmscan: only evict file pages when we have plenty" makes > > a point of not going for anonymous memory while there is still enough > > inactive cache around. > > > > The check was added only for global reclaim, but it is just as useful > > for memory cgroup reclaim. > > > > Signed-off-by: Johannes Weiner > > --- > > mm/vmscan.c | 19 ++++++++++--------- > > 1 file changed, 10 insertions(+), 9 deletions(-) > > > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > index 157bb11..3874dcb 100644 > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -1671,6 +1671,16 @@ static void get_scan_count(struct lruvec *lruvec, struct scan_control *sc, > > denominator = 1; > > goto out; > > } > > + /* > > + * There is enough inactive page cache, do not reclaim > > + * anything from the anonymous working set right now. > > + */ > > + if (!inactive_file_is_low(lruvec)) { > > + fraction[0] = 0; > > + fraction[1] = 1; > > + denominator = 1; > > + goto out; > > + } > > > > anon = get_lru_size(lruvec, LRU_ACTIVE_ANON) + > > get_lru_size(lruvec, LRU_INACTIVE_ANON); > > @@ -1688,15 +1698,6 @@ static void get_scan_count(struct lruvec *lruvec, struct scan_control *sc, > > fraction[1] = 0; > > denominator = 1; > > goto out; > > - } else if (!inactive_file_is_low_global(zone)) { > > - /* > > - * There is enough inactive page cache, do not > > - * reclaim anything from the working set right now. > > - */ > > - fraction[0] = 0; > > - fraction[1] = 1; > > - denominator = 1; > > - goto out; > > } > > } > > > > > > I believe the if() block should be moved to AFTER > the check where we make sure we actually have enough > file pages. Where check enough file pages? if (unlikely(file + free <= high_wmark_pages(zone))), correct? > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org