linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: linux-mm@kvack.org
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Subject: [PATCH] CMA: call to putback_lru_pages
Date: Mon, 17 Dec 2012 13:25:04 -0800	[thread overview]
Message-ID: <1355779504-30798-1-git-send-email-srinivas.pandruvada@linux.intel.com> (raw)

As per documentation and other places calling putback_lru_pages,
on error only, except for CMA. I am not sure this is a problem
for CMA or not.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
 mm/page_alloc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 83637df..5a887bf 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -5802,8 +5802,8 @@ static int __alloc_contig_migrate_range(struct compact_control *cc,
 				    alloc_migrate_target,
 				    0, false, MIGRATE_SYNC);
 	}
-
-	putback_movable_pages(&cc->migratepages);
+	if (ret < 0)
+		putback_movable_pages(&cc->migratepages);
 	return ret > 0 ? 0 : ret;
 }
 
-- 
1.7.11.7

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2012-12-17 21:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-17 21:25 Srinivas Pandruvada [this message]
2012-12-17 22:24 ` [PATCH] CMA: call to putback_lru_pages Michal Nazarewicz
2012-12-18  9:58   ` Marek Szyprowski
2012-12-19 23:27   ` Andrew Morton
2012-12-20 15:13     ` Michal Nazarewicz
2012-12-20 18:59       ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1355779504-30798-1-git-send-email-srinivas.pandruvada@linux.intel.com \
    --to=srinivas.pandruvada@linux.intel.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).