* [PATCH 1/5] staging: ramster: disable build in anticipation of renaming
2013-01-17 17:26 [PATCH 0/5] staging: zcache: move new zcache code base from ramster Dan Magenheimer
@ 2013-01-17 17:26 ` Dan Magenheimer
2013-01-17 17:26 ` [PATCH 2/5] staging: zcache: rename ramster to zcache Dan Magenheimer
` (4 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Dan Magenheimer @ 2013-01-17 17:26 UTC (permalink / raw)
To: devel, linux-kernel, gregkh, linux-mm, ngupta, konrad.wilk,
sjenning, minchan, dan.magenheimer
In staging, disable ramster build in anticipation of renaming to zcache
Signed-off-by: Dan Magenheimer <dan.magenheimer@oracle.com>
---
drivers/staging/Kconfig | 2 --
drivers/staging/Makefile | 1 -
2 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig
index db8a512..eb61455 100644
--- a/drivers/staging/Kconfig
+++ b/drivers/staging/Kconfig
@@ -126,8 +126,6 @@ source "drivers/staging/csr/Kconfig"
source "drivers/staging/omap-thermal/Kconfig"
-source "drivers/staging/ramster/Kconfig"
-
source "drivers/staging/silicom/Kconfig"
source "drivers/staging/ced1401/Kconfig"
diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile
index a9d5479..18420b8 100644
--- a/drivers/staging/Makefile
+++ b/drivers/staging/Makefile
@@ -55,7 +55,6 @@ obj-$(CONFIG_USB_G_CCG) += ccg/
obj-$(CONFIG_WIMAX_GDM72XX) += gdm72xx/
obj-$(CONFIG_CSR_WIFI) += csr/
obj-$(CONFIG_OMAP_BANDGAP) += omap-thermal/
-obj-$(CONFIG_ZCACHE2) += ramster/
obj-$(CONFIG_NET_VENDOR_SILICOM) += silicom/
obj-$(CONFIG_CED1401) += ced1401/
obj-$(CONFIG_DRM_IMX) += imx-drm/
--
1.7.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/5] staging: zcache: rename ramster to zcache
2013-01-17 17:26 [PATCH 0/5] staging: zcache: move new zcache code base from ramster Dan Magenheimer
2013-01-17 17:26 ` [PATCH 1/5] staging: ramster: disable build in anticipation of renaming Dan Magenheimer
@ 2013-01-17 17:26 ` Dan Magenheimer
2013-01-18 20:46 ` Greg KH
2013-01-17 17:26 ` [PATCH 3/5] staging: zcache: adjustments to config/build files due to renaming Dan Magenheimer
` (3 subsequent siblings)
5 siblings, 1 reply; 10+ messages in thread
From: Dan Magenheimer @ 2013-01-17 17:26 UTC (permalink / raw)
To: devel, linux-kernel, gregkh, linux-mm, ngupta, konrad.wilk,
sjenning, minchan, dan.magenheimer
In staging, rename ramster to zcache
The original zcache in staging was a "demo" version, and this new zcache
is a significant rewrite. While certain disagreements were being resolved,
both "old zcache" and "new zcache" needed to reside in the staging tree
simultaneously. In order to minimize code change and churn, the newer
version of zcache was temporarily merged into the "ramster" staging driver
which, prior to that, had at one time heavily leveraged the older version
of zcache. So, recently, "new zcache" resided in the ramster directory.
Got that? No? Sorry, temporary political compromises are rarely pretty.
The older version of zcache is no longer being maintained and has now
been removed from the staging tree. So now the newer version of zcache
can rightfully reclaim sole possession of the name "zcache".
This patch is simply a manual:
# git mv drivers/staging/ramster drivers/staging/zcache
so the actual patch diff has been left out.
Because a git mv loses history, part of the original description of
the changes between "old zcache" and "new zcache" is repeated below:
Some of the highlights of this rewritten codebase for zcache:
(Note: If you are not familiar with the tmem terminology, you can review
it here: http://lwn.net/Articles/454795/ )
1. Merge of "demo" zcache and the v1.1 version of zcache in ramster. Zcache
and ramster had a great deal of duplicate code which is now merged.
In essence, zcache now *is* ramster but with no remote machine available,
but !CONFIG_RAMSTER will avoid compiling lots of ramster-specific code.
2. Allocator. Previously, persistent pools used zsmalloc and ephemeral pools
used zbud. Now a completely rewritten zbud is used for both. Notably
this zbud maintains all persistent (frontswap) and ephemeral (cleancache)
pageframes in separate queues in LRU order.
3. Interaction with page allocator. Zbud does no page allocation/freeing,
it is done entirely in zcache where it can be tracked more effectively.
4. Better pre-allocation. Previously, on put, if a new pageframe could not be
pre-allocated, the put would fail, even if the allocator had plenty of
partial pages where the data could be stored; this is now fixed.
5. Ouroboros ("eating its own tail") allocation. If no pageframe can be
allocated AND no partial pages are available, the least-recently-used
ephemeral pageframe is reclaimed immediately (including flushing tmem
pointers to it) and re-used. This ensures that most-recently-used
cleancache pages are more likely to be retained than LRU pages and also
that, as in the core mm subsystem, anonymous pages have a higher priority
than clean page cache pages.
6. Zcache and zbud now use debugfs instead of sysfs. Ramster uses debugfs
where possible and sysfs where necessary. (Some ramster configuration
is done from userspace so some sysfs is necessary.)
7. Modularization. As some have observed, the monolithic zcache-main.c code
included zbud code, which has now been separated into its own code module.
Much ramster-specific code in the old ramster zcache-main.c has also been
moved into ramster.c so that it does not get compiled with !CONFIG_RAMSTER.
8. Rebased to 3.5.
This new codebase also provides hooks for several future new features:
A. WasActive patch, requires some mm/frontswap changes previously posted.
A new version of this patch will be provided separately.
See ifdef __PG_WAS_ACTIVE
B. Exclusive gets. It seems tmem _can_ support exclusive gets with a
minor change to both zcache and a small backwards-compatible change
to frontswap.c. Explanation and frontswap patch will be provided
separately. See ifdef FRONTSWAP_HAS_EXCLUSIVE_GETS
C. Ouroboros writeback. Since persistent (frontswap) pages may now also be
reclaimed in LRU order, the foundation is in place to properly writeback
these pages back into the swap cache and then the swap disk. This is still
under development and requires some other mm changes which are prototyped.
See ifdef FRONTSWAP_HAS_UNUSE.
A new feature that desperately needs attention (if someone is looking for
a way to contribute) is kernel module support. A preliminary version of
a patch was posted by Erlangen University and needs to be integrated and
tested for zcache and brought up to kernel standards.
If anybody is interested on helping out with any of these, let me know!
Original zcache rewrite was:
Signed-off-by: Dan Magenheimer <dan.magenheimer@oracle.com>
Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
This "git mv" patch which changes only file locations in staging is:
Signed-off-by: Dan Magenheimer <dan.magenheimer@oracle.com>
---
drivers/staging/ramster/Kconfig | 31 -
drivers/staging/ramster/Makefile | 6 -
drivers/staging/ramster/ramster.h | 59 -
drivers/staging/ramster/ramster/heartbeat.c | 462 ----
drivers/staging/ramster/ramster/heartbeat.h | 87 -
drivers/staging/ramster/ramster/masklog.c | 155 --
drivers/staging/ramster/ramster/masklog.h | 220 --
drivers/staging/ramster/ramster/nodemanager.c | 995 ---------
drivers/staging/ramster/ramster/nodemanager.h | 88 -
drivers/staging/ramster/ramster/r2net.c | 414 ----
drivers/staging/ramster/ramster/ramster.c | 985 ---------
drivers/staging/ramster/ramster/ramster.h | 161 --
.../staging/ramster/ramster/ramster_nodemanager.h | 39 -
drivers/staging/ramster/ramster/tcp.c | 2253 --------------------
drivers/staging/ramster/ramster/tcp.h | 159 --
drivers/staging/ramster/ramster/tcp_internal.h | 248 ---
drivers/staging/ramster/tmem.c | 894 --------
drivers/staging/ramster/tmem.h | 259 ---
drivers/staging/ramster/zbud.c | 1060 ---------
drivers/staging/ramster/zbud.h | 33 -
drivers/staging/ramster/zcache-main.c | 1820 ----------------
drivers/staging/ramster/zcache.h | 53 -
drivers/staging/zcache/Kconfig | 31 +
drivers/staging/zcache/Makefile | 6 +
drivers/staging/zcache/ramster.h | 59 +
drivers/staging/zcache/ramster/heartbeat.c | 462 ++++
drivers/staging/zcache/ramster/heartbeat.h | 87 +
drivers/staging/zcache/ramster/masklog.c | 155 ++
drivers/staging/zcache/ramster/masklog.h | 220 ++
drivers/staging/zcache/ramster/nodemanager.c | 995 +++++++++
drivers/staging/zcache/ramster/nodemanager.h | 88 +
drivers/staging/zcache/ramster/r2net.c | 414 ++++
drivers/staging/zcache/ramster/ramster.c | 985 +++++++++
drivers/staging/zcache/ramster/ramster.h | 161 ++
.../staging/zcache/ramster/ramster_nodemanager.h | 39 +
drivers/staging/zcache/ramster/tcp.c | 2253 ++++++++++++++++++++
drivers/staging/zcache/ramster/tcp.h | 159 ++
drivers/staging/zcache/ramster/tcp_internal.h | 248 +++
drivers/staging/zcache/tmem.c | 894 ++++++++
drivers/staging/zcache/tmem.h | 259 +++
drivers/staging/zcache/zbud.c | 1060 +++++++++
drivers/staging/zcache/zbud.h | 33 +
drivers/staging/zcache/zcache-main.c | 1820 ++++++++++++++++
drivers/staging/zcache/zcache.h | 53 +
44 files changed, 10481 insertions(+), 10481 deletions(-)
delete mode 100644 drivers/staging/ramster/Kconfig
delete mode 100644 drivers/staging/ramster/Makefile
delete mode 100644 drivers/staging/ramster/ramster.h
delete mode 100644 drivers/staging/ramster/ramster/heartbeat.c
delete mode 100644 drivers/staging/ramster/ramster/heartbeat.h
delete mode 100644 drivers/staging/ramster/ramster/masklog.c
delete mode 100644 drivers/staging/ramster/ramster/masklog.h
delete mode 100644 drivers/staging/ramster/ramster/nodemanager.c
delete mode 100644 drivers/staging/ramster/ramster/nodemanager.h
delete mode 100644 drivers/staging/ramster/ramster/r2net.c
delete mode 100644 drivers/staging/ramster/ramster/ramster.c
delete mode 100644 drivers/staging/ramster/ramster/ramster.h
delete mode 100644 drivers/staging/ramster/ramster/ramster_nodemanager.h
delete mode 100644 drivers/staging/ramster/ramster/tcp.c
delete mode 100644 drivers/staging/ramster/ramster/tcp.h
delete mode 100644 drivers/staging/ramster/ramster/tcp_internal.h
delete mode 100644 drivers/staging/ramster/tmem.c
delete mode 100644 drivers/staging/ramster/tmem.h
delete mode 100644 drivers/staging/ramster/zbud.c
delete mode 100644 drivers/staging/ramster/zbud.h
delete mode 100644 drivers/staging/ramster/zcache-main.c
delete mode 100644 drivers/staging/ramster/zcache.h
create mode 100644 drivers/staging/zcache/Kconfig
create mode 100644 drivers/staging/zcache/Makefile
create mode 100644 drivers/staging/zcache/ramster.h
create mode 100644 drivers/staging/zcache/ramster/heartbeat.c
create mode 100644 drivers/staging/zcache/ramster/heartbeat.h
create mode 100644 drivers/staging/zcache/ramster/masklog.c
create mode 100644 drivers/staging/zcache/ramster/masklog.h
create mode 100644 drivers/staging/zcache/ramster/nodemanager.c
create mode 100644 drivers/staging/zcache/ramster/nodemanager.h
create mode 100644 drivers/staging/zcache/ramster/r2net.c
create mode 100644 drivers/staging/zcache/ramster/ramster.c
create mode 100644 drivers/staging/zcache/ramster/ramster.h
create mode 100644 drivers/staging/zcache/ramster/ramster_nodemanager.h
create mode 100644 drivers/staging/zcache/ramster/tcp.c
create mode 100644 drivers/staging/zcache/ramster/tcp.h
create mode 100644 drivers/staging/zcache/ramster/tcp_internal.h
create mode 100644 drivers/staging/zcache/tmem.c
create mode 100644 drivers/staging/zcache/tmem.h
create mode 100644 drivers/staging/zcache/zbud.c
create mode 100644 drivers/staging/zcache/zbud.h
create mode 100644 drivers/staging/zcache/zcache-main.c
create mode 100644 drivers/staging/zcache/zcache.h
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/5] staging: zcache: rename ramster to zcache
2013-01-17 17:26 ` [PATCH 2/5] staging: zcache: rename ramster to zcache Dan Magenheimer
@ 2013-01-18 20:46 ` Greg KH
2013-01-18 20:54 ` Dan Magenheimer
0 siblings, 1 reply; 10+ messages in thread
From: Greg KH @ 2013-01-18 20:46 UTC (permalink / raw)
To: Dan Magenheimer
Cc: devel, linux-kernel, linux-mm, ngupta, konrad.wilk, sjenning,
minchan
On Thu, Jan 17, 2013 at 09:26:34AM -0800, Dan Magenheimer wrote:
> In staging, rename ramster to zcache
>
> The original zcache in staging was a "demo" version, and this new zcache
> is a significant rewrite. While certain disagreements were being resolved,
> both "old zcache" and "new zcache" needed to reside in the staging tree
> simultaneously. In order to minimize code change and churn, the newer
> version of zcache was temporarily merged into the "ramster" staging driver
> which, prior to that, had at one time heavily leveraged the older version
> of zcache. So, recently, "new zcache" resided in the ramster directory.
>
> Got that? No? Sorry, temporary political compromises are rarely pretty.
>
> The older version of zcache is no longer being maintained and has now
> been removed from the staging tree. So now the newer version of zcache
> can rightfully reclaim sole possession of the name "zcache".
>
> This patch is simply a manual:
>
> # git mv drivers/staging/ramster drivers/staging/zcache
>
> so the actual patch diff has been left out.
>
> Because a git mv loses history, part of the original description of
> the changes between "old zcache" and "new zcache" is repeated below:
git mv does not loose history, it can handle it just fine.
greg k-h
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH 2/5] staging: zcache: rename ramster to zcache
2013-01-18 20:46 ` Greg KH
@ 2013-01-18 20:54 ` Dan Magenheimer
0 siblings, 0 replies; 10+ messages in thread
From: Dan Magenheimer @ 2013-01-18 20:54 UTC (permalink / raw)
To: Greg KH
Cc: devel, linux-kernel, linux-mm, ngupta, Konrad Wilk, sjenning,
minchan
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Friday, January 18, 2013 1:47 PM
> To: Dan Magenheimer
> Cc: devel@linuxdriverproject.org; linux-kernel@vger.kernel.org; linux-mm@kvack.org; ngupta@vflare.org;
> Konrad Wilk; sjenning@linux.vnet.ibm.com; minchan@kernel.org
> Subject: Re: [PATCH 2/5] staging: zcache: rename ramster to zcache
>
> On Thu, Jan 17, 2013 at 09:26:34AM -0800, Dan Magenheimer wrote:
> > In staging, rename ramster to zcache
> >
> > The original zcache in staging was a "demo" version, and this new zcache
> > is a significant rewrite. While certain disagreements were being resolved,
> > both "old zcache" and "new zcache" needed to reside in the staging tree
> > simultaneously. In order to minimize code change and churn, the newer
> > version of zcache was temporarily merged into the "ramster" staging driver
> > which, prior to that, had at one time heavily leveraged the older version
> > of zcache. So, recently, "new zcache" resided in the ramster directory.
> >
> > Got that? No? Sorry, temporary political compromises are rarely pretty.
> >
> > The older version of zcache is no longer being maintained and has now
> > been removed from the staging tree. So now the newer version of zcache
> > can rightfully reclaim sole possession of the name "zcache".
> >
> > This patch is simply a manual:
> >
> > # git mv drivers/staging/ramster drivers/staging/zcache
> >
> > so the actual patch diff has been left out.
> >
> > Because a git mv loses history, part of the original description of
> > the changes between "old zcache" and "new zcache" is repeated below:
>
> git mv does not loose history, it can handle it just fine.
OK will fix. Heh, apparently, you learn something wrong on the internet
("git mv loses history") every day, too. :-(
Thanks,
Dan
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 3/5] staging: zcache: adjustments to config/build files due to renaming
2013-01-17 17:26 [PATCH 0/5] staging: zcache: move new zcache code base from ramster Dan Magenheimer
2013-01-17 17:26 ` [PATCH 1/5] staging: ramster: disable build in anticipation of renaming Dan Magenheimer
2013-01-17 17:26 ` [PATCH 2/5] staging: zcache: rename ramster to zcache Dan Magenheimer
@ 2013-01-17 17:26 ` Dan Magenheimer
2013-01-17 17:26 ` [PATCH 4/5] staging: zcache: re-enable config/build of zcache after renaming Dan Magenheimer
` (2 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Dan Magenheimer @ 2013-01-17 17:26 UTC (permalink / raw)
To: devel, linux-kernel, gregkh, linux-mm, ngupta, konrad.wilk,
sjenning, minchan, dan.magenheimer
In staging/zcache, adjust config/build due to ramster->zcache renaming
Signed-off-by: Dan Magenheimer <dan.magenheimer@oracle.com>
---
drivers/staging/zcache/Kconfig | 17 ++++++-----------
drivers/staging/zcache/Makefile | 2 +-
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/zcache/Kconfig b/drivers/staging/zcache/Kconfig
index 3abf661..c1dbd04 100644
--- a/drivers/staging/zcache/Kconfig
+++ b/drivers/staging/zcache/Kconfig
@@ -1,23 +1,18 @@
-config ZCACHE2
+config ZCACHE
bool "Dynamic compression of swap pages and clean pagecache pages"
- depends on CRYPTO=y && SWAP=y && CLEANCACHE && FRONTSWAP && !ZCACHE
+ depends on CRYPTO=y && SWAP=y && CLEANCACHE && FRONTSWAP
select CRYPTO_LZO
default n
help
- Zcache2 doubles RAM efficiency while providing a significant
- performance boosts on many workloads. Zcache2 uses
+ Zcache doubles RAM efficiency while providing a significant
+ performance boosts on many workloads. Zcache uses
compression and an in-kernel implementation of transcendent
memory to store clean page cache pages and swap in RAM,
- providing a noticeable reduction in disk I/O. Zcache2
- is a complete rewrite of the older zcache; it was intended to
- be a merge but that has been blocked due to political and
- technical disagreements. It is intended that they will merge
- again in the future. Until then, zcache2 is a single-node
- version of ramster.
+ providing a noticeable reduction in disk I/O.
config RAMSTER
bool "Cross-machine RAM capacity sharing, aka peer-to-peer tmem"
- depends on CONFIGFS_FS=y && SYSFS=y && !HIGHMEM && ZCACHE2=y
+ depends on CONFIGFS_FS=y && SYSFS=y && !HIGHMEM && ZCACHE=y
depends on NET
# must ensure struct page is 8-byte aligned
select HAVE_ALIGNED_STRUCT_PAGE if !64_BIT
diff --git a/drivers/staging/zcache/Makefile b/drivers/staging/zcache/Makefile
index 2d8b9d0..4711049 100644
--- a/drivers/staging/zcache/Makefile
+++ b/drivers/staging/zcache/Makefile
@@ -3,4 +3,4 @@ zcache-$(CONFIG_RAMSTER) += ramster/ramster.o ramster/r2net.o
zcache-$(CONFIG_RAMSTER) += ramster/nodemanager.o ramster/tcp.o
zcache-$(CONFIG_RAMSTER) += ramster/heartbeat.o ramster/masklog.o
-obj-$(CONFIG_ZCACHE2) += zcache.o
+obj-$(CONFIG_ZCACHE) += zcache.o
--
1.7.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 4/5] staging: zcache: re-enable config/build of zcache after renaming
2013-01-17 17:26 [PATCH 0/5] staging: zcache: move new zcache code base from ramster Dan Magenheimer
` (2 preceding siblings ...)
2013-01-17 17:26 ` [PATCH 3/5] staging: zcache: adjustments to config/build files due to renaming Dan Magenheimer
@ 2013-01-17 17:26 ` Dan Magenheimer
2013-01-17 17:26 ` [PATCH 5/5] staging: zcache: fix uninitialized variable compile warning Dan Magenheimer
2013-01-18 20:46 ` [PATCH 0/5] staging: zcache: move new zcache code base from ramster Greg KH
5 siblings, 0 replies; 10+ messages in thread
From: Dan Magenheimer @ 2013-01-17 17:26 UTC (permalink / raw)
To: devel, linux-kernel, gregkh, linux-mm, ngupta, konrad.wilk,
sjenning, minchan, dan.magenheimer
In staging, re-enable config/build of zcache after ramster->zcache renaming.
Signed-off-by: Dan Magenheimer <dan.magenheimer@oracle.com>
---
drivers/staging/Kconfig | 2 ++
drivers/staging/Makefile | 1 +
2 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig
index eb61455..0b47a06 100644
--- a/drivers/staging/Kconfig
+++ b/drivers/staging/Kconfig
@@ -138,4 +138,6 @@ source "drivers/staging/sb105x/Kconfig"
source "drivers/staging/fwserial/Kconfig"
+source "drivers/staging/zcache/Kconfig"
+
endif # STAGING
diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile
index 18420b8..b026ea3 100644
--- a/drivers/staging/Makefile
+++ b/drivers/staging/Makefile
@@ -61,3 +61,4 @@ obj-$(CONFIG_DRM_IMX) += imx-drm/
obj-$(CONFIG_DGRP) += dgrp/
obj-$(CONFIG_SB105X) += sb105x/
obj-$(CONFIG_FIREWIRE_SERIAL) += fwserial/
+obj-$(CONFIG_ZCACHE) += zcache/
--
1.7.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 5/5] staging: zcache: fix uninitialized variable compile warning
2013-01-17 17:26 [PATCH 0/5] staging: zcache: move new zcache code base from ramster Dan Magenheimer
` (3 preceding siblings ...)
2013-01-17 17:26 ` [PATCH 4/5] staging: zcache: re-enable config/build of zcache after renaming Dan Magenheimer
@ 2013-01-17 17:26 ` Dan Magenheimer
2013-01-18 20:46 ` [PATCH 0/5] staging: zcache: move new zcache code base from ramster Greg KH
5 siblings, 0 replies; 10+ messages in thread
From: Dan Magenheimer @ 2013-01-17 17:26 UTC (permalink / raw)
To: devel, linux-kernel, gregkh, linux-mm, ngupta, konrad.wilk,
sjenning, minchan, dan.magenheimer
Fix unitialized variable in zcache which generates warning during build
Signed-off-by: Dan Magenheimer <dan.magenheimer@oracle.com>
---
drivers/staging/zcache/zcache-main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/zcache/zcache-main.c b/drivers/staging/zcache/zcache-main.c
index a09dd5c..6ab13e1 100644
--- a/drivers/staging/zcache/zcache-main.c
+++ b/drivers/staging/zcache/zcache-main.c
@@ -1346,7 +1346,7 @@ static int zcache_local_new_pool(uint32_t flags)
int zcache_autocreate_pool(unsigned int cli_id, unsigned int pool_id, bool eph)
{
struct tmem_pool *pool;
- struct zcache_client *cli;
+ struct zcache_client *cli = NULL;
uint32_t flags = eph ? 0 : TMEM_POOL_PERSIST;
int ret = -1;
--
1.7.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 0/5] staging: zcache: move new zcache code base from ramster
2013-01-17 17:26 [PATCH 0/5] staging: zcache: move new zcache code base from ramster Dan Magenheimer
` (4 preceding siblings ...)
2013-01-17 17:26 ` [PATCH 5/5] staging: zcache: fix uninitialized variable compile warning Dan Magenheimer
@ 2013-01-18 20:46 ` Greg KH
2013-01-18 20:53 ` Dan Magenheimer
5 siblings, 1 reply; 10+ messages in thread
From: Greg KH @ 2013-01-18 20:46 UTC (permalink / raw)
To: Dan Magenheimer
Cc: devel, linux-kernel, linux-mm, ngupta, konrad.wilk, sjenning,
minchan
On Thu, Jan 17, 2013 at 09:26:32AM -0800, Dan Magenheimer wrote:
> Hi Greg --
>
> With "old zcache" now removed, we can now move "new zcache" from its
> temporary home (in drivers/staging/ramster) to reclaim sole possession
> of the name "zcache".
>
> Note that [PATCH 2/5] will require a manual:
>
> # git mv drivers/staging/ramster drivers/staging/zcache
Ick, no, use git to generate the patch with rename style, and it will
create the tiny patch that does this which I can then apply (-M is the
option you want to 'git format-patch').
Care to resend this in that format so that I can apply this properly?
thanks,
greg k-h
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH 0/5] staging: zcache: move new zcache code base from ramster
2013-01-18 20:46 ` [PATCH 0/5] staging: zcache: move new zcache code base from ramster Greg KH
@ 2013-01-18 20:53 ` Dan Magenheimer
0 siblings, 0 replies; 10+ messages in thread
From: Dan Magenheimer @ 2013-01-18 20:53 UTC (permalink / raw)
To: Greg KH
Cc: devel, linux-kernel, linux-mm, ngupta, Konrad Wilk, sjenning,
minchan
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Subject: Re: [PATCH 0/5] staging: zcache: move new zcache code base from ramster
>
> On Thu, Jan 17, 2013 at 09:26:32AM -0800, Dan Magenheimer wrote:
> > Hi Greg --
> >
> > With "old zcache" now removed, we can now move "new zcache" from its
> > temporary home (in drivers/staging/ramster) to reclaim sole possession
> > of the name "zcache".
> >
> > Note that [PATCH 2/5] will require a manual:
> >
> > # git mv drivers/staging/ramster drivers/staging/zcache
>
> Ick, no, use git to generate the patch with rename style, and it will
> create the tiny patch that does this which I can then apply (-M is the
> option you want to 'git format-patch').
>
> Care to resend this in that format so that I can apply this properly?
Will do. You learn something new (-M) every day.
Thanks,
Dan
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 10+ messages in thread