From: Minchan Kim <minchan@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Hugh Dickins <hughd@google.com>,
Sangseok Lee <sangseok.lee@lge.com>,
Minchan Kim <minchan@kernel.org>
Subject: [RFC 2/4] mm: make shrink_page_list with pages from multiple zones
Date: Mon, 25 Mar 2013 15:21:32 +0900 [thread overview]
Message-ID: <1364192494-22185-2-git-send-email-minchan@kernel.org> (raw)
In-Reply-To: <1364192494-22185-1-git-send-email-minchan@kernel.org>
Now shrink_page_list expects all pages come from a same zone
but it's too limited to use it.
This patch removes the dependency so next patch can use
shrink_page_list with pages from multiple zones.
Signed-off-by: Minchan Kim <minchan@kernel.org>
---
mm/vmscan.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index d3dc95f..9434ba2 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -705,7 +705,8 @@ static unsigned long shrink_page_list(struct list_head *page_list,
goto keep;
VM_BUG_ON(PageActive(page));
- VM_BUG_ON(page_zone(page) != zone);
+ if (zone)
+ VM_BUG_ON(page_zone(page) != zone);
sc->nr_scanned++;
@@ -951,7 +952,7 @@ keep:
* back off and wait for congestion to clear because further reclaim
* will encounter the same problem
*/
- if (nr_dirty && nr_dirty == nr_congested && global_reclaim(sc))
+ if (nr_dirty && nr_dirty == nr_congested && global_reclaim(sc) && zone)
zone_set_flag(zone, ZONE_CONGESTED);
free_hot_cold_page_list(&free_pages, 1);
--
1.8.2
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-03-25 6:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 6:21 [RFC 1/4] mm: Per process reclaim Minchan Kim
2013-03-25 6:21 ` Minchan Kim [this message]
2013-03-25 6:21 ` [RFC 3/4] mm: Remove shrink_page Minchan Kim
2013-03-25 6:21 ` [RFC 4/4] mm: Enhance per process reclaim Minchan Kim
2013-04-02 13:25 ` Michael Kerrisk
2013-04-03 0:23 ` Minchan Kim
2013-04-03 6:16 ` Michael Kerrisk (man-pages)
2013-04-03 6:47 ` Michael Kerrisk (man-pages)
2013-04-03 9:17 ` [RFC 1/4] mm: Per " Michael Kerrisk
2013-04-03 23:31 ` Minchan Kim
2013-04-03 10:10 ` Michael Kerrisk
2013-04-03 10:12 ` Michael Kerrisk
2013-04-03 23:46 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364192494-22185-2-git-send-email-minchan@kernel.org \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=riel@redhat.com \
--cc=sangseok.lee@lge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).