linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Lin Feng <linfeng@cn.fujitsu.com>
To: akpm@linux-foundation.org
Cc: cl@linux.com, tglx@linutronix.de, mingo@redhat.com,
	hpa@zytor.com, yinghai@kernel.org, catalin.marinas@arm.com,
	will.deacon@arm.com, arnd@arndb.de, tony@atomide.com,
	ben@decadent.org.uk, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, x86@kernel.org, linux-mm@kvack.org,
	isimatu.yasuaki@jp.fujitsu.com, Lin Feng <linfeng@cn.fujitsu.com>
Subject: [PATCH 1/2] mm: vmemmap: x86: add vmemmap_verify check for hot-add node case
Date: Mon, 8 Apr 2013 17:56:39 +0800	[thread overview]
Message-ID: <1365415000-10389-2-git-send-email-linfeng@cn.fujitsu.com> (raw)
In-Reply-To: <1365415000-10389-1-git-send-email-linfeng@cn.fujitsu.com>

In hot add node(memory) case, vmemmap pages are always allocated from other
node, but the current logic just skip vmemmap_verify check.
So we should also issue "potential offnode page_structs" warning messages
if we are the case.

Cc: Christoph Lameter <cl@linux.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Yinghai Lu <yinghai@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Reported-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Signed-off-by: Lin Feng <linfeng@cn.fujitsu.com>
---
 arch/x86/mm/init_64.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
index 474e28f..e2a7277 100644
--- a/arch/x86/mm/init_64.c
+++ b/arch/x86/mm/init_64.c
@@ -1318,6 +1318,8 @@ vmemmap_populate(struct page *start_page, unsigned long size, int node)
 			if (!p)
 				return -ENOMEM;
 
+			vmemmap_verify((pte_t *)p, node, addr, addr + PAGE_SIZE);
+
 			addr_end = addr + PAGE_SIZE;
 			p_end = p + PAGE_SIZE;
 		} else {
@@ -1347,8 +1349,8 @@ vmemmap_populate(struct page *start_page, unsigned long size, int node)
 
 				addr_end = addr + PMD_SIZE;
 				p_end = p + PMD_SIZE;
-			} else
-				vmemmap_verify((pte_t *)pmd, node, addr, next);
+			}
+			vmemmap_verify((pte_t *)pmd, node, addr, next);
 		}
 
 	}
-- 
1.8.0.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2013-04-08 10:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-08  9:56 [PATCH 0/2] mm: vmemmap: add vmemmap_verify check for hot-add node/memory case Lin Feng
2013-04-08  9:56 ` Lin Feng [this message]
2013-04-08 10:23   ` [PATCH 1/2] mm: vmemmap: x86: add vmemmap_verify check for hot-add node case Lin Feng
2013-04-08  9:56 ` [PATCH 2/2] mm: vmemmap: arm64: " Lin Feng
2013-04-08 10:55   ` Will Deacon
2013-04-09  2:07     ` Lin Feng
2013-04-08 18:40 ` [PATCH 0/2] mm: vmemmap: add vmemmap_verify check for hot-add node/memory case Yinghai Lu
2013-04-08 20:55   ` Andrew Morton
2013-04-09  1:58     ` Lin Feng
2013-04-09  2:02   ` Lin Feng
2013-04-11  7:41   ` Tang Chen
2013-04-11 15:10     ` Yinghai Lu
2013-04-12  1:13       ` Tang Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365415000-10389-2-git-send-email-linfeng@cn.fujitsu.com \
    --to=linfeng@cn.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=ben@decadent.org.uk \
    --cc=catalin.marinas@arm.com \
    --cc=cl@linux.com \
    --cc=hpa@zytor.com \
    --cc=isimatu.yasuaki@jp.fujitsu.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=tony@atomide.com \
    --cc=will.deacon@arm.com \
    --cc=x86@kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).