From: Toshi Kani <toshi.kani@hp.com>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linuxram@us.ibm.com, guz.fnst@cn.fujitsu.com, tmac@hp.com,
isimatu.yasuaki@jp.fujitsu.com, wency@cn.fujitsu.com,
tangchen@cn.fujitsu.com, jiang.liu@huawei.com,
Toshi Kani <toshi.kani@hp.com>
Subject: [PATCH v2 3/3] mm: Change __remove_pages() to call release_mem_region_adjustable()
Date: Mon, 8 Apr 2013 11:09:56 -0600 [thread overview]
Message-ID: <1365440996-30981-4-git-send-email-toshi.kani@hp.com> (raw)
In-Reply-To: <1365440996-30981-1-git-send-email-toshi.kani@hp.com>
Changed __remove_pages() to call release_mem_region_adjustable().
This allows a requested memory range to be released from
the iomem_resource table even if it does not match exactly to
an resource entry but still fits into. The resource entries
initialized at bootup usually cover the whole contiguous
memory ranges and may not necessarily match with the size of
memory hot-delete requests.
If release_mem_region_adjustable() failed, __remove_pages() logs
an error message and continues to proceed as it was the case
with release_mem_region(). release_mem_region(), which is defined
to __release_region(), logs an error message and returns no error
since a void function.
Signed-off-by: Toshi Kani <toshi.kani@hp.com>
Reviewed-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
---
mm/memory_hotplug.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 57decb2..c916582 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -705,8 +705,10 @@ EXPORT_SYMBOL_GPL(__add_pages);
int __remove_pages(struct zone *zone, unsigned long phys_start_pfn,
unsigned long nr_pages)
{
- unsigned long i, ret = 0;
+ unsigned long i;
int sections_to_remove;
+ resource_size_t start, size;
+ int ret = 0;
/*
* We can only remove entire sections
@@ -714,7 +716,12 @@ int __remove_pages(struct zone *zone, unsigned long phys_start_pfn,
BUG_ON(phys_start_pfn & ~PAGE_SECTION_MASK);
BUG_ON(nr_pages % PAGES_PER_SECTION);
- release_mem_region(phys_start_pfn << PAGE_SHIFT, nr_pages * PAGE_SIZE);
+ start = phys_start_pfn << PAGE_SHIFT;
+ size = nr_pages * PAGE_SIZE;
+ ret = release_mem_region_adjustable(&iomem_resource, start, size);
+ if (ret)
+ pr_warn("Unable to release resource <%016llx-%016llx> (%d)\n",
+ start, start + size - 1, ret);
sections_to_remove = nr_pages / PAGES_PER_SECTION;
for (i = 0; i < sections_to_remove; i++) {
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-04-08 17:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 17:09 [PATCH v2 0/3] Support memory hot-delete to boot memory Toshi Kani
2013-04-08 17:09 ` [PATCH v2 1/3] resource: Add __adjust_resource() for internal use Toshi Kani
2013-04-10 6:10 ` David Rientjes
2013-04-10 15:39 ` Toshi Kani
2013-04-08 17:09 ` [PATCH v2 2/3] resource: Add release_mem_region_adjustable() Toshi Kani
2013-04-10 6:16 ` David Rientjes
2013-04-10 16:36 ` Toshi Kani
2013-04-08 17:09 ` Toshi Kani [this message]
2013-04-08 20:44 ` [PATCH v2 0/3] Support memory hot-delete to boot memory Andrew Morton
2013-04-08 20:58 ` Toshi Kani
2013-04-10 5:52 ` David Rientjes
2013-04-10 6:07 ` [patch] mm, hotplug: avoid compiling memory hotremove functions when disabled David Rientjes
2013-04-10 17:29 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365440996-30981-4-git-send-email-toshi.kani@hp.com \
--to=toshi.kani@hp.com \
--cc=akpm@linux-foundation.org \
--cc=guz.fnst@cn.fujitsu.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=jiang.liu@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxram@us.ibm.com \
--cc=tangchen@cn.fujitsu.com \
--cc=tmac@hp.com \
--cc=wency@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).