linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, Andi Kleen <ak@linux.intel.com>, mgorman@suse.de
Subject: [PATCH] mm: Print the correct method to disable automatic numa migration
Date: Wed, 10 Apr 2013 12:35:14 -0700	[thread overview]
Message-ID: <1365622514-26614-1-git-send-email-andi@firstfloor.org> (raw)

From: Andi Kleen <ak@linux.intel.com>

When the "default y" CONFIG_NUMA_BALANCING_DEFAULT_ENABLED is enabled,
the message it prints refers to a sysctl to disable it again.
But that sysctl doesn't exist.

Document the correct (highly obscure method) through debugfs.

This should be also in Documentation/* but isn't.

Also fix the checkpatch problems.

BTW I think the "default y" is highly dubious for such a
experimential feature.

Cc: mgorman@suse.de
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
 mm/mempolicy.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index 7431001..8a4dc29 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -2530,8 +2530,8 @@ static void __init check_numabalancing_enable(void)
 		numabalancing_default = true;
 
 	if (nr_node_ids > 1 && !numabalancing_override) {
-		printk(KERN_INFO "Enabling automatic NUMA balancing. "
-			"Configure with numa_balancing= or sysctl");
+		pr_info("Enabling automatic NUMA balancing.\n");
+		pr_info("Change with numa_balancing= or echo -NUMA >/sys/kernel/debug/sched_features\n");
 		set_numabalancing_state(numabalancing_default);
 	}
 }
-- 
1.7.7.6

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2013-04-10 19:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-10 19:35 Andi Kleen [this message]
2013-04-10 21:15 ` [PATCH] mm: Print the correct method to disable automatic numa migration David Rientjes
2013-04-10 21:26   ` Andi Kleen
2013-04-10 21:29     ` David Rientjes
2013-04-11 12:48 ` Mel Gorman
2013-04-11 14:04   ` Andi Kleen
2013-04-11 14:19     ` Mel Gorman
2013-04-11 15:53       ` Andi Kleen
2013-04-11 17:25         ` Mel Gorman
2013-04-11 17:39           ` Andi Kleen
2013-04-11 17:48             ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365622514-26614-1-git-send-email-andi@firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).