From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx140.postini.com [74.125.245.140]) by kanga.kvack.org (Postfix) with SMTP id 230F26B003D for ; Thu, 11 Apr 2013 21:14:29 -0400 (EDT) Received: from /spool/local by e35.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 11 Apr 2013 19:14:28 -0600 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id EC18B3E4003F for ; Thu, 11 Apr 2013 19:14:13 -0600 (MDT) Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3C1EQk0164870 for ; Thu, 11 Apr 2013 19:14:26 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3C1EQ4v018235 for ; Thu, 11 Apr 2013 19:14:26 -0600 From: Cody P Schafer Subject: [RFC PATCH v2 09/25] page_alloc: when dynamic numa is enabled, don't check that all pages in a block belong to the same zone Date: Thu, 11 Apr 2013 18:13:41 -0700 Message-Id: <1365729237-29711-10-git-send-email-cody@linux.vnet.ibm.com> In-Reply-To: <1365729237-29711-1-git-send-email-cody@linux.vnet.ibm.com> References: <1365729237-29711-1-git-send-email-cody@linux.vnet.ibm.com> Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Mel Gorman , Linux MM , LKML , Cody P Schafer , Simon Jeons When dynamic numa is enabled, the last or first page in a pageblock may have been transplanted to a new zone (or may not yet be transplanted to a new zone). Disable a BUG_ON() which checks that the start_page and end_page are in the same zone, if they are not in the proper zone they will simply be skipped. Signed-off-by: Cody P Schafer --- mm/page_alloc.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 75192eb..95e4a23 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -959,13 +959,16 @@ int move_freepages(struct zone *zone, int pages_moved = 0; int zone_nid = zone_to_nid(zone); -#ifndef CONFIG_HOLES_IN_ZONE +#if !defined(CONFIG_HOLES_IN_ZONE) && !defined(CONFIG_DYNAMIC_NUMA) /* - * page_zone is not safe to call in this context when - * CONFIG_HOLES_IN_ZONE is set. This bug check is probably redundant - * anyway as we check zone boundaries in move_freepages_block(). - * Remove at a later date when no bug reports exist related to - * grouping pages by mobility + * With CONFIG_HOLES_IN_ZONE set, this check is unsafe as start_page or + * end_page may not be "valid". + * With CONFIG_DYNAMIC_NUMA set, this condition is a valid occurence & + * not a bug. + * + * This bug check is probably redundant anyway as we check zone + * boundaries in move_freepages_block(). Remove at a later date when + * no bug reports exist related to grouping pages by mobility */ BUG_ON(page_zone(start_page) != page_zone(end_page)); #endif -- 1.8.2.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org