From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DED8DC54E76 for ; Mon, 20 Nov 2023 14:09:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1AD336B0432; Mon, 20 Nov 2023 09:09:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 136546B043E; Mon, 20 Nov 2023 09:09:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F406C6B0440; Mon, 20 Nov 2023 09:09:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DE7D66B0432 for ; Mon, 20 Nov 2023 09:09:35 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B145414080B for ; Mon, 20 Nov 2023 14:09:35 +0000 (UTC) X-FDA: 81478515510.22.7A64D51 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf23.hostedemail.com (Postfix) with ESMTP id CF05B140009 for ; Mon, 20 Nov 2023 14:09:33 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=r45lYZBB; spf=pass (imf23.hostedemail.com: domain of broonie@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700489374; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fqLOa9NPfUrT/YacAJxDNrtd2jdmP5iiWqMCSLA0jbQ=; b=03Mc8kpIzs/a/awhVY7U2leGD/eQIQbEV6PxkTWshW0SyaQt29+3RHnWdguAJDirYCOs5E tgErb/1N9bNuvNcA1o+SeyWxq2LRKL2zVDyvKi5la5GccoZtKxwJMvZWN5c1nJprHJGEAq FlmfLCSUo2zqErqi94+prrsoynYfQ+s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700489374; a=rsa-sha256; cv=none; b=1EXNVf60QGFk1zL1M6EDHbbeV0cechOO+cTnZm7bebOb14yM+JzrBlei5ku7vnmLwSQR/X kWacFHlXqeRA6jTWIwlvPWRBEXcqSitXeO5MVIT5hbH5d0DicM6EWSJAU8N0DWaQAsrQHT X0J1VOfZLrhzYQq+W2pAGxL/+JfL/Pk= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=r45lYZBB; spf=pass (imf23.hostedemail.com: domain of broonie@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 6F364B817E5; Mon, 20 Nov 2023 14:09:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A142C433C9; Mon, 20 Nov 2023 14:09:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700489371; bh=hoIhA8+0yRB+8xKNhUqRCTi4Cj0Q9PRSELx11+Gdf9k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r45lYZBBqyt2qIC3VTWvXeFOLpp7CslcoudAqZHo3c3ToiD3advJLwF+LCeQTSM4V ian9GJtKKF/6WQNbnSlPU6HPsyneu0ZkHaso51fhQyb5HfooUycrugoOjqW3AvaFvH JbSyG7Q6aiUwYwnG9OQSQDRK4H2FDhgaP+yGZfOW9mvm9hc6UiF2csU75mRMpuJsB/ u1dCYBO9SVZu1FuLumVUvtcx32ALSNqXSMdsp9G0IufrXorcmRf7kCkpyLAOe7IGza CZVtn9hq2ML7D6TA2ZoEM+IA98iwR0d/sA7ltvFzg0zveh92v1bjHGQjv6XIUZ6hjb x08JifS0gmx4Q== Date: Mon, 20 Nov 2023 14:09:17 +0000 From: Mark Brown To: Anish Moorthy Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Sean Christopherson , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Fuad Tabba , Jarkko Sakkinen , David Matlack , Yu Zhang , Isaku Yamahata , =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A. Shutemov" Subject: Re: [PATCH 34/34] KVM: selftests: Add a memory region subtest to validate invalid flags Message-ID: <13677ced-e464-4cdb-82ae-4236536e169c@sirena.org.uk> References: <20231105163040.14904-1-pbonzini@redhat.com> <20231105163040.14904-35-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="61dY8WQ8Ox8wOW0h" Content-Disposition: inline In-Reply-To: X-Cookie: Happiness is twin floppies. X-Rspamd-Queue-Id: CF05B140009 X-Rspam-User: X-Stat-Signature: ns8azgmzjz99g6a7fnubuc95meakpopu X-Rspamd-Server: rspam03 X-HE-Tag: 1700489373-362137 X-HE-Meta: U2FsdGVkX1+t9OSLpIabJSx5eo8bXTPVScPyD5dAJEuwjo+e9l26kAkoyjxb0IGQsxQdcjtO/J+UbkuLQ3X4n3yuT0I4zocrNzg14k7vpdKn9SmSs+PrEaZ6lGbO/WtIeCfbhmT2ATwmc71bqY24fPWZWha9H3glVluYUCz7/IOqR38QgwI/9HkVEQUiyuXoqIx/ycOPfXbCMCLReoEDq8iRTAWtxUP+fH3Z9MTHkwNAtqifIDG3MFRZwGmg7See3Lkpfl1tkfbqK8TWzwYmA8ETatVjIN/aJFurznLfXeelST4QRJLj2yvstbJbGAqBb1sNws6XRigO5GP9fdyXG4c0rZYdMf4UNQsWvhMMZlwAYFA21jTTl+ilJj77AvxHyJuzLixXrXKIJNppLCKjfGK+4w2VYCsjoPv1+LfmkRGQFBv0mwc3vyTNqBq5g6dJ6zh1J73T8ZNGPdMNl87mKTJ+dK1VLJVABUg95RP2236nHLp8Kqr//1KVZtYAWyK0al2taG4aTjU4UCGxjCXmA95WqjRAYiejV1zkgXgYTixT+4rahTgf33jCWpiGo3kjNRnjJ7s4mQWwyu3jsFG898XKB9K4e0BrQczArOZI8zqpAHN0AbD+2MzmMtyyG1Z76Mpv5ukvIUVLMGxDHIqdpyqs9/HGdD+q+8GhxGjiN/vrk5rB/yXHvPgPHBM94VVsNFcSKX2U2W3yOGKw+8IxmQLyLp2B0B5hkjDSTjKHCG6ZihDEYSRY/baW7TGcz/OQWjljUpFIWK73lflhqbu1+FfOTTJnZ1EatEprNS2nMs3k4fCq6XPCGdZvd9AoWByfv6fkopsk92Hz+o05l/3tXvvbevwAx2r7EmvzGRU4mkFht9SdyT30LR4TX/z30J2ALlMNnA6+NNi7Ye6Cg2WQX5AQ0tT9EAp0sFKL83yBFGYlQYMYDvwvMeuZaYlVH3ae0O74UMzheI7EsG6NqJW 23sd+aK2 P4kVzoaJp1hd68XfyP7xQVv8lpJ8HzH1cigfTTET+CzJiy/OrfxcRBKNG4Q8ynf9faj6L7L18VGtR3XyIRqAC6AAggUhNxwpNYamyogjrgD7k+nlebDuxv5CnrDDnTrOOv0CMwoEqdaf8YNtZWzLN1LguInd22je0WnDurh5Jg572PV4A6T60KBgWJq2nQVEZ7CFJqA19E31Bk+jpCtUcRwqzWTqNpdarwHDT58KLSGAHobUzVyJb/dtbPnI//JABg4Kf5ymfS9ZMzuYUKlUkrbAVvmazlZ88f7tF4iN6qruB8474RFoI0+IH7lXqgpecCP9J303aD/o7YXkWHryFDBSTtg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --61dY8WQ8Ox8wOW0h Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 08, 2023 at 05:08:01PM -0800, Anish Moorthy wrote: > Applying [1] and [2] reveals that this also breaks non-x86 builds- the > MEM_REGION_GPA/SLOT definitions are guarded behind an #ifdef > __x86_64__, while the usages introduced here aren't. >=20 > Should >=20 > On Sun, Nov 5, 2023 at 8:35=E2=80=AFAM Paolo Bonzini wrote: > > > > + test_invalid_memory_region_flags(); >=20 > be #ifdef'd, perhaps? I'm not quite sure what the intent is. This has been broken in -next for a week now, do we have any progress on a fix or should we just revert the patch? --61dY8WQ8Ox8wOW0h Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmVbaI0ACgkQJNaLcl1U h9Aj2Qf9EbUUwOLmAwUa3Jl4QMfiLrKntsPjxIsD9MYRWpqfdGr2gZb7wNXozUgD A1SOrSPxLG5lvE3dOdXD1O/mzrxVwLcfAssVQ6KjXu13pJtZDIQHAUpYQBJL28QR KIeV8OVDMKeFryWnyt+y92xYK+7d4TocCuAq2Ph3jQj/OIXp4bI5quuTV58jmIG4 1QuJFi73b7JIL4Ksmg32pp3aWaoP7BqMqnDxx92GwdngF0Jrg1NBhgHoMkh/J28y zT6Vui1HZF2pSrrxexqXFLJKhveYmLyg3kaoEyvYeRwj/WjZSB3U/9LJrhBDctTJ 2Y23Hu9kFWuPdJxy0l8BV7AiIxSr4Q== =GWvB -----END PGP SIGNATURE----- --61dY8WQ8Ox8wOW0h--