From: Minchan Kim <minchan@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Rik van Riel <riel@redhat.com>,
Michael Kerrisk <mtk.manpages@gmail.com>,
Dave Hansen <dave.hansen@intel.com>,
Namhyung Kim <namhyung@kernel.org>,
Minkyung Kim <minkyung88@lge.com>,
Minchan Kim <minchan@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Mel Gorman <mgorman@suse.de>
Subject: [PATCH v5 1/7] mm: prevent to write out dirty page in CMA by may_writepage
Date: Thu, 9 May 2013 16:21:23 +0900 [thread overview]
Message-ID: <1368084089-24576-2-git-send-email-minchan@kernel.org> (raw)
In-Reply-To: <1368084089-24576-1-git-send-email-minchan@kernel.org>
Now, local variable references in shrink_page_list is
PAGEREF_RECLAIM_CLEAN as default. It is for preventing to reclaim
dirty pages when CMA try to migrate pages.
Strictly speaking, we don't need it because CMA already didn't allow
to write out by .may_writepage = 0 in reclaim_clean_pages_from_list.
Morever, it has a problem to prevent anonymous pages's swap out when
we use force_reclaim = true in shrink_page_list(ex, per process reclaim
can do it)
So this patch makes references's default value to PAGEREF_RECLAIM
and declare .may_writepage = 0 of scan_control in CMA part to make
code more clear.
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Mel Gorman <mgorman@suse.de>
Reported-by: Minkyung Kim <minkyung88@lge.com>
Signed-off-by: Minchan Kim <minchan@kernel.org>
---
mm/vmscan.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index fa6a853..c22f9c1 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -695,7 +695,7 @@ static unsigned long shrink_page_list(struct list_head *page_list,
struct address_space *mapping;
struct page *page;
int may_enter_fs;
- enum page_references references = PAGEREF_RECLAIM_CLEAN;
+ enum page_references references = PAGEREF_RECLAIM;
cond_resched();
@@ -972,6 +972,8 @@ unsigned long reclaim_clean_pages_from_list(struct zone *zone,
.gfp_mask = GFP_KERNEL,
.priority = DEF_PRIORITY,
.may_unmap = 1,
+ /* Doesn't allow to write out dirty page */
+ .may_writepage = 0,
};
unsigned long ret, dummy1, dummy2;
struct page *page, *next;
--
1.8.2.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-05-09 7:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 7:21 [PATCH v5 0/7] Per process reclaim Minchan Kim
2013-05-09 7:21 ` Minchan Kim [this message]
2013-05-09 7:21 ` [PATCH v5 2/7] mm: " Minchan Kim
2013-05-09 7:21 ` [PATCH v5 3/7] mm: make shrink_page_list with pages work from multiple zones Minchan Kim
2013-05-09 7:21 ` [PATCH v5 4/7] mm: Remove shrink_page Minchan Kim
2013-05-09 7:21 ` [PATCH v5 5/7] mm: Enhance per process reclaim to consider shared pages Minchan Kim
2013-05-09 7:21 ` [PATCH v5 6/7] mm: Support address range reclaim Minchan Kim
2013-05-22 0:33 ` Andrew Morton
2013-05-27 8:24 ` Minchan Kim
2013-05-09 7:21 ` [PATCH v5 7/7] add documentation about reclaim knob on proc.txt Minchan Kim
2013-05-21 23:16 ` [PATCH v5 0/7] Per process reclaim Andrew Morton
2013-05-27 8:12 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368084089-24576-2-git-send-email-minchan@kernel.org \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m.szyprowski@samsung.com \
--cc=mgorman@suse.de \
--cc=minkyung88@lge.com \
--cc=mtk.manpages@gmail.com \
--cc=namhyung@kernel.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).