linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Jiang Liu <liuj97@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jiang Liu <jiang.liu@huawei.com>,
	David Rientjes <rientjes@google.com>,
	Wen Congyang <wency@cn.fujitsu.com>, Mel Gorman <mgorman@suse.de>,
	Minchan Kim <minchan@kernel.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Michal Hocko <mhocko@suse.cz>,
	James Bottomley <James.Bottomley@HansenPartnership.com>,
	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	David Howells <dhowells@redhat.com>,
	Mark Salter <msalter@redhat.com>,
	Jianguo Wu <wujianguo@huawei.com>,
	linux-mm@kvack.org, linux-arch@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Yinghai Lu <yinghai@kernel.org>,
	Tang Chen <tangchen@cn.fujitsu.com>
Subject: [PATCH v6, part3 04/16] mm/x86: use free_reserved_area() to simplify code
Date: Sun, 12 May 2013 01:34:37 +0800	[thread overview]
Message-ID: <1368293689-16410-5-git-send-email-jiang.liu@huawei.com> (raw)
In-Reply-To: <1368293689-16410-1-git-send-email-jiang.liu@huawei.com>

Use common help function free_reserved_area() to simplify code.

Signed-off-by: Jiang Liu <jiang.liu@huawei.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org
Cc: Yinghai Lu <yinghai@kernel.org>
Cc: Tang Chen <tangchen@cn.fujitsu.com>
Cc: Wen Congyang <wency@cn.fujitsu.com>
Cc: Jianguo Wu <wujianguo@huawei.com>
Cc: linux-kernel@vger.kernel.org
---
 arch/x86/mm/init.c    | 14 +++-----------
 arch/x86/mm/init_64.c |  5 ++---
 2 files changed, 5 insertions(+), 14 deletions(-)

diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
index fed9993..9048d94 100644
--- a/arch/x86/mm/init.c
+++ b/arch/x86/mm/init.c
@@ -494,7 +494,6 @@ int devmem_is_allowed(unsigned long pagenr)
 
 void free_init_pages(char *what, unsigned long begin, unsigned long end)
 {
-	unsigned long addr;
 	unsigned long begin_aligned, end_aligned;
 
 	/* Make sure boundaries are page aligned */
@@ -509,8 +508,6 @@ void free_init_pages(char *what, unsigned long begin, unsigned long end)
 	if (begin >= end)
 		return;
 
-	addr = begin;
-
 	/*
 	 * If debugging page accesses then do not free this memory but
 	 * mark them not present - any buggy init-section access will
@@ -529,18 +526,13 @@ void free_init_pages(char *what, unsigned long begin, unsigned long end)
 	set_memory_nx(begin, (end - begin) >> PAGE_SHIFT);
 	set_memory_rw(begin, (end - begin) >> PAGE_SHIFT);
 
-	printk(KERN_INFO "Freeing %s: %luk freed\n", what, (end - begin) >> 10);
-
-	for (; addr < end; addr += PAGE_SIZE) {
-		memset((void *)addr, POISON_FREE_INITMEM, PAGE_SIZE);
-		free_reserved_page(virt_to_page(addr));
-	}
+	free_reserved_area(begin, end, POISON_FREE_INITMEM, what);
 #endif
 }
 
 void free_initmem(void)
 {
-	free_init_pages("unused kernel memory",
+	free_init_pages("unused kernel",
 			(unsigned long)(&__init_begin),
 			(unsigned long)(&__init_end));
 }
@@ -566,7 +558,7 @@ void __init free_initrd_mem(unsigned long start, unsigned long end)
 	 *   - relocate_initrd()
 	 * So here We can do PAGE_ALIGN() safely to get partial page to be freed
 	 */
-	free_init_pages("initrd memory", start, PAGE_ALIGN(end));
+	free_init_pages("initrd", start, PAGE_ALIGN(end));
 }
 #endif
 
diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
index bb00c46..32e2f25 100644
--- a/arch/x86/mm/init_64.c
+++ b/arch/x86/mm/init_64.c
@@ -1166,11 +1166,10 @@ void mark_rodata_ro(void)
 	set_memory_ro(start, (end-start) >> PAGE_SHIFT);
 #endif
 
-	free_init_pages("unused kernel memory",
+	free_init_pages("unused kernel",
 			(unsigned long) __va(__pa_symbol(text_end)),
 			(unsigned long) __va(__pa_symbol(rodata_start)));
-
-	free_init_pages("unused kernel memory",
+	free_init_pages("unused kernel",
 			(unsigned long) __va(__pa_symbol(rodata_end)),
 			(unsigned long) __va(__pa_symbol(_sdata)));
 }
-- 
1.8.1.2

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2013-05-11 17:40 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-11 17:34 [PATCH v6, part3 00/16] accurately calculate memory statisitic information Jiang Liu
2013-05-11 17:34 ` [PATCH v6, part3 01/16] mm: change signature of free_reserved_area() to fix building warnings Jiang Liu
2013-05-11 17:34 ` [PATCH v6, part3 02/16] mm: enhance free_reserved_area() to support poisoning memory with zero Jiang Liu
2013-05-11 17:34 ` [PATCH v6, part3 03/16] mm/ARM64: kill poison_init_mem() Jiang Liu
2013-05-11 17:34 ` Jiang Liu [this message]
2013-05-11 17:34 ` [PATCH v6, part3 05/16] mm/tile: use common help functions to free reserved pages Jiang Liu
2013-05-11 17:34 ` [PATCH v6, part3 06/16] mm, powertv: use free_reserved_area() to simplify code Jiang Liu
2013-05-11 17:34 ` [PATCH v6, part3 07/16] mm, acornfb: " Jiang Liu
2013-05-11 17:34 ` [PATCH v6, part3 08/16] mm: fix some trivial typos in comments Jiang Liu
2013-05-11 17:34 ` [PATCH v6, part3 09/16] mm: use managed_pages to calculate default zonelist order Jiang Liu
2013-05-11 17:34 ` [PATCH v6, part3 10/16] mm: accurately calculate zone->managed_pages for highmem zones Jiang Liu
2013-05-11 17:34 ` [PATCH v6, part3 11/16] mm: use a dedicated lock to protect totalram_pages and zone->managed_pages Jiang Liu
2013-05-11 17:34 ` [PATCH v6, part3 12/16] mm: make __free_pages_bootmem() only available at boot time Jiang Liu
2013-05-11 17:34 ` [PATCH v6, part3 13/16] mm: correctly update zone->mamaged_pages Jiang Liu
2013-05-11 17:34 ` [PATCH v6, part3 14/16] mm: concentrate modification of totalram_pages into the mm core Jiang Liu
2013-05-11 17:34 ` [PATCH v6, part3 15/16] mm: report available pages as "MemTotal" for each NUMA node Jiang Liu
2013-05-11 20:05   ` Sergei Shtylyov
2013-05-12 15:13     ` Liu Jiang
2013-05-11 17:34 ` [PATCH v6, part3 16/16] AVR32: fix building warnings caused by redifinitions of HZ Jiang Liu
2013-05-13  9:19 ` [PATCH v6, part3 14/16] mm: concentrate modification of totalram_pages into the mm core David Howells
2013-05-13  9:40 ` [PATCH v6, part3 16/16] AVR32: fix building warnings caused by redifinitions of HZ David Howells
2013-05-17 15:28   ` Liu Jiang
2013-05-13  9:41 ` [PATCH v6, part3 02/16] mm: enhance free_reserved_area() to support poisoning memory with zero David Howells
2013-05-13  9:42 ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1368293689-16410-5-git-send-email-jiang.liu@huawei.com \
    --to=liuj97@gmail.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=hpa@zytor.com \
    --cc=jiang.liu@huawei.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mhocko@suse.cz \
    --cc=minchan@kernel.org \
    --cc=mingo@redhat.com \
    --cc=msalter@redhat.com \
    --cc=rientjes@google.com \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=tangchen@cn.fujitsu.com \
    --cc=tglx@linutronix.de \
    --cc=wency@cn.fujitsu.com \
    --cc=wujianguo@huawei.com \
    --cc=x86@kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).