linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Glauber Costa <glommer@gmail.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: linux-mm <linux-mm@kvack.org>, cgroups <cgroups@vger.kernel.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Glauber Costa <glommer@openvz.org>
Subject: [PATCH v2 0/2] slightly rework memcg cache id determination
Date: Fri, 14 Jun 2013 14:04:34 -0400	[thread overview]
Message-ID: <1371233076-936-1-git-send-email-glommer@openvz.org> (raw)

Michal,

Let me know if this is more acceptable to you. I didn't take your suggestion of
having an id and idx functions, because I think this could potentially be even
more confusing: in the sense that people would need to wonder a bit what is the
difference between them.

Note please that we never use the id as an array index outside of memcg core.
So for memcg core, I have changed, in Patch 2, each direct use of idx as an
index to include a VM_BUG_ON in case we would get an invalid index.

For the other cases, I have consolidated a bit the usage pattern around
memcg_cache_id.  Now the tests are all pretty standardized.

Glauber Costa (2):
  memcg: make cache index determination more robust
  memcg: consolidate callers of memcg_cache_id

 mm/memcontrol.c | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

-- 
1.8.1.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2013-06-14 18:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-14 18:04 Glauber Costa [this message]
2013-06-14 18:04 ` [PATCH v2 1/2] memcg: make cache index determination more robust Glauber Costa
2013-06-14 18:04 ` [PATCH v2 2/2] memcg: consolidate callers of memcg_cache_id Glauber Costa
2013-06-17 13:30 ` [PATCH v2 0/2] slightly rework memcg cache id determination Michal Hocko
2013-06-17 23:13   ` Glauber Costa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371233076-936-1-git-send-email-glommer@openvz.org \
    --to=glommer@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=glommer@openvz.org \
    --cc=hannes@cmpxchg.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).